Skip to content

Introduce a different review process for design proposals #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qinsoon opened this issue Nov 3, 2023 · 1 comment
Closed

Introduce a different review process for design proposals #1012

qinsoon opened this issue Nov 3, 2023 · 1 comment
Labels
A-meta Area: Meta issues for the repository P-high Priority: High. A high-priority issue should be fixed as soon as possible.

Comments

@qinsoon
Copy link
Member

qinsoon commented Nov 3, 2023

Steve suggested that design has profound impact, and a design proposal cannot be well evaluated by our CI, nor our normal code review process. We should have a different review process for design proposals. Like Rust's RFC, and OpenJDK's JEP. The idea is to have a more vigorous review process to deal with design changes, and to avoid wasting efforts on implementation before the design is approved.

It is yet unclear: 1. what should be categorised as a design change, and 2. what process we should adopt for design proposals.

@qinsoon qinsoon added the A-meta Area: Meta issues for the repository label Nov 3, 2023
@k-sareen k-sareen added the P-high Priority: High. A high-priority issue should be fixed as soon as possible. label Nov 6, 2023
@qinsoon
Copy link
Member Author

qinsoon commented Jan 1, 2024

We introduced MEP in #1056, and #1041 tracks our discussion about MEP. This issue can be closed.

Answering the two questions in the issues:

  1. What should be categorised as a design change: MEP focuses on changes that may have future impacts on the project.
  2. What process we should adopt for design proposals: Unlike normal PR reviews which is only reviewed by certain reviewers, MEP reviews need the consensus from the MMTk team. See https://github.com/mmtk/mmtk-core/blob/master/docs/contribute/mep.md#mep-reviewing-process.

@qinsoon qinsoon closed this as completed Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Meta issues for the repository P-high Priority: High. A high-priority issue should be fixed as soon as possible.
Projects
None yet
Development

No branches or pull requests

2 participants