Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make creates .c files in the main source folder #2

Open
koffie opened this issue Aug 11, 2017 · 4 comments
Open

make creates .c files in the main source folder #2

koffie opened this issue Aug 11, 2017 · 4 comments

Comments

@koffie
Copy link
Contributor

koffie commented Aug 11, 2017

I just tried using this template and found out that the way this package is building the cython code is quite messy, since it leaves a .c file in the same folder as the pyx file. This is going to be really annoying, since you don't want to add *.c to gitignore, and you also don't want to check which c file you have to manually remove while doing make clean.

@koffie
Copy link
Contributor Author

koffie commented Aug 11, 2017

I did a bit of reading on cython and maybe this is hard to fix since it is the way that cython works (i.e. it doesn't have a directive that allows you to give a "build" directory. The way sage seems to fix this problem, is to first copy over the entire source to a new directory and then build there.

@mmasdeu
Copy link
Owner

mmasdeu commented Aug 23, 2017

Well, let's hope that the projects don't contain a large number of cython files for now...

@mmasdeu mmasdeu closed this as completed Aug 23, 2017
@koffie
Copy link
Contributor Author

koffie commented Aug 23, 2017

I agree that fixing it right now is maybe not necessary. But I think the issue should not be closed, since it really is an issue which we might want to keep track of.

@mmasdeu mmasdeu reopened this Aug 23, 2017
@mmasdeu
Copy link
Owner

mmasdeu commented Aug 23, 2017

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants