Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submission checker for power submission #400

Open
4 of 5 tasks
pgmpablo157321 opened this issue Dec 6, 2024 · 2 comments · May be fixed by #402
Open
4 of 5 tasks

Add submission checker for power submission #400

pgmpablo157321 opened this issue Dec 6, 2024 · 2 comments · May be fixed by #402
Assignees

Comments

@pgmpablo157321
Copy link
Contributor

pgmpablo157321 commented Dec 6, 2024

  • Check folder structure
  • Check file names + check no file is missing (#switches & #nodes)
    • Possibly check with system configuration files
    • Alternatively check that number of files (#switches & #nodes) is the same and from 1 to n
  • Check keys + format inside power log files
@pgmpablo157321 pgmpablo157321 self-assigned this Dec 6, 2024
@pgmpablo157321 pgmpablo157321 linked a pull request Jan 9, 2025 that will close this issue
@hanyunfan
Copy link

I have verified this one, and I believe it can be merged as all the behaviors are expected without issue.

Below are what I had tested:

  1. If only 1 sw_0.txt file (the record for switch power) is missing. The output is correct, checker will have a warning message and still accept the results based on the Olympic scoring rule.
    Image

  2. If missing 2 sw_0.txt file. Error message got generated as expected.
    Image

  3. It is not a bug, but I'd like to mention it: the checker will give the power folder a warning message, just like it did on the scaling.json file. This is not an issue, I believe the current way will work.
    Image
    Image

Thanks,
Frank

@hiwotadese
Copy link
Contributor

@pgmpablo157321 can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants