load from csv component #21
Conversation
There was a problem hiding this comment.
Thanks @Hakimovich99! Looks good apart from some minor comments.
| @@ -0,0 +1,29 @@ | |||
| name: Load from csv file | |||
| description: Component that loads a dataset from huggingface hub | |||
| image: hakimovich99/load_from_csv:dev #TODO: change it to fndnt once implemented | |||
There was a problem hiding this comment.
You can use the ml6team github container registry for any components related to a use case.
There was a problem hiding this comment.
Just to make sure, like that: ghcr.io/ml6team/load_from_csv:dev ?
There was a problem hiding this comment.
Yes. You can label them to link them to this repo.
See this script for instance, it uses the fondant build command.
| @@ -0,0 +1,29 @@ | |||
| name: Load from csv file | |||
| description: Component that loads a dataset from huggingface hub | |||
There was a problem hiding this comment.
This file should not be in here.
There was a problem hiding this comment.
The pre-commit check doesn't work if I don't set this file: src/components/text_cleaning/src/main.py: error: Duplicate module named "main" (also at "src/components/load_from_csv/src/main.py")
There was a problem hiding this comment.
Yes, the mypy pre-commit doesn't work well in a multi-repo. However adding the __init__.py files is only a band-aid and will not solve it. Feel free to remove the mypy pre-commit, we did it in other use case repositories as well. Eg. here.
There was a problem hiding this comment.
Ah nice I was wondering if there was a way to deactivate it instead, thanks!
Thanks for the feedback!
There was a problem hiding this comment.
I don't think this file needs to be in here?
There was a problem hiding this comment.
Indeed thanks!
RobbeSneyders
deleted the
16-implement-component-to-load-evaluation-data
branch
No description provided.