Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tsip/struct.py #30

Open
mjuenema opened this issue Oct 28, 2017 · 0 comments
Open

Refactor tsip/struct.py #30

mjuenema opened this issue Oct 28, 2017 · 0 comments
Assignees
@mjuenema
Labels
enhancement
Milestone
0.5.0

Comments

@mjuenema
Copy link
Owner

  • Have base class for Struct0xNN() style classes.
  • Have ReportPacket() and RequestPacket() base classes.
  • Calling .pack() on report packets and .unpack() on request packets should raise NotImplementedError and remove the existing code.
@mjuenema mjuenema self-assigned this Oct 28, 2017
@mjuenema mjuenema added this to the 0.5.0 milestone Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjuenema mjuenema

Labels
enhancement
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@mjuenema