refactor: reorder func params

Reorder function parameters to consistently place structs created
by other functions as the first parameter.

For example: `ordered_array_get(ordered_array_t*, ...);`

Author: mjcheetham

src/ordered_array.c

@@ -26,7 +26,7 @@ void ordered_array_destroy(ordered_array_t *array)
 	PANIC("not implemented: ordered_array_destroy");
 }
 
-void ordered_array_insert(type_t item, ordered_array_t *array)
+void ordered_array_insert(ordered_array_t *array, type_t item)
 {
 	// Check if the array is already at maximum capacity
 	if (array->size == array->max_size)
@@ -65,16 +65,16 @@ void ordered_array_insert(type_t item, ordered_array_t *array)
 	}
 }
 
-type_t ordered_array_get(uint32_t index, ordered_array_t *array)
+type_t ordered_array_get(ordered_array_t *array, uint32_t index)
 {
 	return array->array[index];
 }
 
-void ordered_array_remove(uint32_t index, ordered_array_t *array)
+void ordered_array_remove(ordered_array_t *array, uint32_t index)
 {
 	for (; index < array->size; index++)
 	{
 		array->array[index] = array->array[index + 1];
 	}
 	array->size--;
-}
+}

src/ordered_array.h

@@ -26,10 +26,10 @@ ordered_array_t ordered_array_place(uint32_t max_size, compare_predicate_t compa
 void ordered_array_destroy(ordered_array_t *array);
 
 // Insert an item into an ordered array.
-void ordered_array_insert(type_t item, ordered_array_t *array);
+void ordered_array_insert(ordered_array_t *array, type_t item);
 
 // Get the item at the given index in an ordered array.
-type_t ordered_array_get(uint32_t index, ordered_array_t *array);
+type_t ordered_array_get(ordered_array_t *array, uint32_t index);
 
 // Remove the item at the given index in an ordered array.
-void ordered_array_remove(uint32_t index, ordered_array_t *array);
+void ordered_array_remove(ordered_array_t *array, uint32_t index);

src/paging.c

@@ -110,7 +110,7 @@ static void switch_directory(page_directory_t *new)
 	asm volatile("mov %0, %%cr0" :: "r" (cr0));
 }
 
-static page_t *get_page(uint32_t address, bool_t create, page_directory_t *dir)
+static page_t *get_page(page_directory_t *dir, uint32_t address, bool_t create)
 {
 	// Turn address into an index
 	uint32_t index = address / PAGE_SIZE;