Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just want to ask a question ? #179

Open
nxtcoder17 opened this issue Jul 28, 2023 · 1 comment
Open

just want to ask a question ? #179

nxtcoder17 opened this issue Jul 28, 2023 · 1 comment

Comments

@nxtcoder17
Copy link
Contributor

nxtcoder17 commented Jul 28, 2023

Hi guys,

currently this project suffers from this problem #104, which more or less leaves only one choice to create new helm clients for each namespaces over which you want to release a chart.

I forked this repo, and made some changes to accomodate that behaviour, because i needed to deploy this client in a k8s reconciler and could not have afforded creating new client on every reconcilation loop.

If you guys think, that should be an acceptable behaviour, then i can drop a pull request with the fix ?

My Observations

Basically, the issues comes up when we create HelmClient without specifying a namespace, refer here

screenshot-9536

followed by this, we have created actionConfig (using the above defined clientGetter), and the same actionConfig is used to perform all the helm operations. refer here

screenshot-26885

AND this exact thing disallows us from applying charts to the specified chartspec.namespace)

I just broke that behaviour, created actionConfig (along with clientGetter) lazily, wherever they are required, like as in (helmclient.install, or helmclient.update calls). And it works ...

@nxtcoder17
Copy link
Contributor Author

nxtcoder17 commented Jul 28, 2023

@elenz97 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant