Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Github project in Error message #55

Open
LukasFritzeDev opened this issue Sep 10, 2023 · 2 comments
Open

Add link to Github project in Error message #55

LukasFritzeDev opened this issue Sep 10, 2023 · 2 comments

Comments

@LukasFritzeDev
Copy link
Contributor

The error messages include the hint to open a bug report.

Please provide this when opening a bug report.

I think it would be be useful to add a link to this Github project to save the user searching for the project.

@LukasFritzeDev LukasFritzeDev changed the title Add linkt to Guthub project in Error message Add link to Guthub project in Error message Sep 10, 2023
@LukasFritzeDev
Copy link
Contributor Author

Just recognised some errors already include this link:

╭──────────────────────────────────────────────────────────────────────────────╮
│ ERROR                                                                        │
│                                                                              │
│ An error occurred while executing this command:                              │
│                                                                              │
│   Error: Filter flag has an invalid value                                    │
│                                                                              │
│ If you believe this to be a bug, please open an issue at                     │
│ https://github.com/mittwald/cli/issues/new                                   │
│ (​https://github.com/mittwald/cli/issues/new​).                              │
╰──────────────────────────────────────────────────────────────────────────────╯

But the formatting could be improved (there is no need to print the link twice) and some other errors (see #54) are missing the link.

@martin-helmich
Copy link
Member

Regarding the duplicate link: Is this some rendering variation of the <Link> component? AFAIK it should just render a clickable link into the terminal -- maybe this is some kind of fallback behaviour in case the terminal emulator doesn't support links?

@martin-helmich martin-helmich changed the title Add link to Guthub project in Error message Add link to Github project in Error message Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants