diff --git a/.github/actions/setup-zap/action.yml b/.github/actions/setup-zap/action.yml index a9977063..6e493516 100644 --- a/.github/actions/setup-zap/action.yml +++ b/.github/actions/setup-zap/action.yml @@ -13,7 +13,7 @@ runs: - uses: actions/setup-java@v4 with: distribution: temurin - java-version: 11 + java-version: 17 - name: Get ZAP version id: latest diff --git a/integration_tests/e2e/activityLog.cy.ts b/integration_tests/e2e/activityLog.cy.ts index e796aaa8..4f648832 100644 --- a/integration_tests/e2e/activityLog.cy.ts +++ b/integration_tests/e2e/activityLog.cy.ts @@ -38,6 +38,7 @@ context('Activity log', () => { cy.get('.toggle-menu .toggle-menu__list-item:nth-of-type(2) a').should('contain.text', 'Compact view') cy.get('[data-qa="filter-form"]').within(() => cy.get('h2').should('contain.text', 'Filter activity log')) page.getApplyFiltersButton().should('contain.text', 'Apply filters') + page.getSelectedFiltersBox().should('not.exist') cy.get('[data-qa="keywords"]').within(() => cy.get('label').should('contain.text', 'Keywords')) page.getKeywordsInput().should('exist').should('have.value', '') cy.get('[data-qa="date-from"]').within(() => cy.get('label').should('contain.text', 'Date from')) @@ -159,6 +160,8 @@ context('Activity log', () => { const page = Page.verifyOnPage(ActivityLogPage) page.getKeywordsInput().type(value) page.getApplyFiltersButton().click() + page.getSelectedFiltersBox().find('h2').should('contain.text', 'Selected filters') + page.getSelectedFiltersBox().find('h3:nth-of-type(1)').should('contain.text', 'Search term') page.getSelectedFilterTags().should('have.length', 1) page.getSelectedFilterTag(1).should('contain.text', value) page.getCardHeader('timeline1').should('contain.text', 'Phone call from Eula Schmeler') @@ -172,6 +175,7 @@ context('Activity log', () => { page.getApplyFiltersButton().click() page.getSelectedFilterTag(1).click() page.getSelectedFilterTag(1).should('not.exist') + page.getSelectedFiltersBox().should('not.exist') page.getKeywordsInput().should('have.value', '') page.getCardHeader('timeline1').should('contain.text', 'Video call') }) @@ -183,6 +187,7 @@ context('Activity log', () => { page.getDateFromInput().type(fromDate) page.getDateToInput().type(toDate) page.getApplyFiltersButton().click() + page.getSelectedFiltersBox().find('h3:nth-of-type(1)').should('contain.text', 'Date range') page.getDateFromInput().should('have.value', fromDate) page.getDateToInput().should('have.value', toDate) page.getSelectedFilterTags().should('have.length', 1) @@ -202,6 +207,7 @@ context('Activity log', () => { page.getApplyFiltersButton().click() page.getSelectedFilterTag(1).click() page.getSelectedFilterTag(1).should('not.exist') + page.getSelectedFiltersBox().should('not.exist') page.getDateFromInput().should('have.value', '') page.getDateToInput().should('have.value', '') page.getCardHeader('timeline1').should('contain.text', 'Video call') @@ -216,6 +222,8 @@ context('Activity log', () => { page.getComplianceFilter(2).click() page.getComplianceFilter(3).click() page.getApplyFiltersButton().click() + page.getSelectedFiltersBox().find('h3:nth-of-type(1)').should('contain.text', 'Compliance filters') + page.getSelectedFiltersBox().should('exist') page.getComplianceFilter(1).should('be.checked') page.getComplianceFilter(2).should('be.checked') page.getComplianceFilter(3).should('be.checked') @@ -278,6 +286,9 @@ context('Activity log', () => { page.getComplianceFilter(2).click() page.getComplianceFilter(3).click() page.getApplyFiltersButton().click() + page.getSelectedFiltersBox().find('h3:nth-of-type(1)').should('contain.text', 'Search term') + page.getSelectedFiltersBox().find('h3:nth-of-type(2)').should('contain.text', 'Date range') + page.getSelectedFiltersBox().find('h3:nth-of-type(3)').should('contain.text', 'Compliance filters') page.getSelectedFilterTags().should('have.length', 5) page.getCardHeader('timeline1').should('contain.text', 'Phone call from Eula Schmeler') cy.get('[data-qa="results-count-start"]').should('contain.text', '1') @@ -285,6 +296,7 @@ context('Activity log', () => { cy.get('[data-qa="results-count-total"]').should('contain.text', '1') cy.get('.govuk-pagination').should('not.exist') cy.get('.moj-filter__heading-action a').click() + page.getSelectedFiltersBox().should('not.exist') page.getSelectedFilterTags().should('not.exist') page.getKeywordsInput().should('have.value', '') page.getDateFromInput().should('have.value', '') @@ -459,6 +471,10 @@ context('Activity log', () => { .getNoResults() .find('li:nth-of-type(3)') .should('contain.text', 'removing special characters like characters and accent letters') + page + .getNoResults() + .find('li:nth-of-type(4)') + .should('contain.text', 'using an asterisk (*) to search with a partial keyword, for example app*') }) it('should persist the selected filters when a pagination link is clicked', () => { cy.visit('/case/X000001/activity-log') diff --git a/integration_tests/e2e/personalDetails/disabilities.cy.ts b/integration_tests/e2e/personalDetails/disabilities.cy.ts index 210942dd..06a9fea1 100644 --- a/integration_tests/e2e/personalDetails/disabilities.cy.ts +++ b/integration_tests/e2e/personalDetails/disabilities.cy.ts @@ -5,23 +5,42 @@ context('Contact', () => { it('Contact page is rendered', () => { cy.visit('/case/X000001/personal-details/disabilities') const page = Page.verifyOnPage(DisabilitiesPage) - cy.get('p') - .eq(0) - .within(() => - cy - .get('a') - .invoke('attr', 'href') - .should( - 'equal', - 'https://ndelius-dummy-url/NDelius-war/delius/JSP/deeplink.xhtml?component=EqualityMonitoring&CRN=X000001', - ), - ) + page.assertAnchorElementAtIndexWithin( + 'p', + 0, + 0, + 'https://ndelius-dummy-url/NDelius-war/delius/JSP/deeplink.xhtml?component=EqualityMonitoring&CRN=X000001', + ) + + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 0, 'Disability') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 1, 'Start date') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 2, 'Notes') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 0, 'Dyslexia') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 1, '3 April 2021') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 2, 'Disability Notes') + }) + + it('Contact page is rendered', () => { + cy.visit('/case/X000001/personal-details/disability/0/note/0') + const page = Page.verifyOnPage(DisabilitiesPage) page.assertAnchorElementAtIndexWithin( 'p', 0, 0, 'https://ndelius-dummy-url/NDelius-war/delius/JSP/deeplink.xhtml?component=EqualityMonitoring&CRN=X000001', ) + + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 0, 'Disability') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 1, 'Start date') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 2, 'Note added by') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 3, 'Date added') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__key]', 4, 'Notes') + + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 0, 'Dyslexia') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 1, '3 April 2021') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 2, 'Tom Brady') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 3, '30 October 2024') + page.assertTextAtElementAtIndex('[class=govuk-summary-list__value]', 4, 'Disability Notes') }) }) diff --git a/integration_tests/e2e/risk.cy.ts b/integration_tests/e2e/risk.cy.ts index c4b8c2a5..a4e89e2c 100644 --- a/integration_tests/e2e/risk.cy.ts +++ b/integration_tests/e2e/risk.cy.ts @@ -8,8 +8,11 @@ context('Risk', () => { it('Risk overview page is rendered', () => { cy.visit('/case/X000001/risk') const page = Page.verifyOnPage(RiskPage) - page.getElementData('highScoringNeedsValue').should('contain.text', 'Relationships') - page.getElementData('lowScoringNeedsValue').should('contain.text', 'Accommodation') + page.getElementData('severeScoringNeedsLabel').should('contain.text', 'Severe') + page.getElementData('severeScoringNeedsValue').should('contain.text', 'Relationships') + page.getElementData('standardScoringNeedsLabel').should('contain.text', 'Standard') + page.getElementData('standardScoringNeedsValue').should('contain.text', 'Accommodation') + page.getElementData('noScoreNeedsLabel').should('contain.text', 'Areas without a need score') page.getElementData('noScoreNeedsValue').should('contain.text', 'Emotional wellbeing') page.getElementData('mappa-heading').should('contain.text', 'Cat 0/Level 2') }) diff --git a/integration_tests/pages/activityLog.ts b/integration_tests/pages/activityLog.ts index 64776704..957649e4 100644 --- a/integration_tests/pages/activityLog.ts +++ b/integration_tests/pages/activityLog.ts @@ -5,6 +5,8 @@ export default class ActivityLogPage extends Page { super('Activity log') } + getSelectedFiltersBox = (): PageElement => cy.get('.moj-filter__selected') + getApplyFiltersButton = (): PageElement => cy.get('[data-qa="submit-button"]') getKeywordsInput = (): PageElement => cy.get('[data-qa="keywords"] input') diff --git a/integration_tests/pages/personalDetails/disability.ts b/integration_tests/pages/personalDetails/disability.ts new file mode 100644 index 00000000..33c090a7 --- /dev/null +++ b/integration_tests/pages/personalDetails/disability.ts @@ -0,0 +1,7 @@ +import Page from '../page' + +export default class DisabilityPage extends Page { + constructor() { + super('Disabilities') + } +} diff --git a/server/@types/ActivityLog.type.ts b/server/@types/ActivityLog.type.ts index ed1e765f..4a5e361c 100644 --- a/server/@types/ActivityLog.type.ts +++ b/server/@types/ActivityLog.type.ts @@ -25,7 +25,7 @@ export interface SelectedFilterItem { export interface ActivityLogFiltersResponse extends ActivityLogFilters { errors: Errors - selectedFilterItems: SelectedFilterItem[] + selectedFilterItems: Record complianceOptions: Option[] baseUrl: string queryStr: string diff --git a/server/middleware/filterActivityLog.ts b/server/middleware/filterActivityLog.ts index 9efc0c19..e72427ec 100644 --- a/server/middleware/filterActivityLog.ts +++ b/server/middleware/filterActivityLog.ts @@ -53,7 +53,6 @@ export const filterActivityLog: Route = (req, res, next) => { } return acc }, '') - return queryStr } @@ -73,38 +72,30 @@ export const filterActivityLog: Route = (req, res, next) => { ? `${baseUrl}?${queryStr}&clearFilterKey=${key}&clearFilterValue=${encodeURI(value)}` : `${baseUrl}?clearFilterKey=${key}&clearFilterValue=${encodeURI(value)}` - const selectedFilterItems: SelectedFilterItem[] = Object.entries(filters) + const selectedFilterItems: Record = Object.entries(filters) .filter(([_key, value]) => value) - .reduce((acc, [key, value]) => { - if (Array.isArray(value)) { - for (const text of value) { - acc = [ - ...acc, - { - text: complianceFilterOptions.find(option => option.value === text).text, - href: filterHref(key, text), - }, - ] + .reduce((acc, [filterKey, filterValue]) => { + let value: string | SelectedFilterItem[] = null + if (Array.isArray(filterValue)) { + value = [] + for (const text of filterValue) { + value.push({ + text: complianceFilterOptions.find(option => option.value === text).text, + href: filterHref(filterKey, text), + }) } - } else if (key !== 'dateTo') { - let text = value - let cfKey = key - if (key === 'dateFrom') { - text = value && filters.dateTo ? `${value} - ${filters.dateTo}` : '' - cfKey = 'dateRange' + } else if (filterKey !== 'dateTo') { + let text = filterValue + if (filterKey === 'dateFrom') { + text = filterValue && filters.dateTo ? `${filterValue} - ${filters.dateTo}` : '' + filterKey = 'dateRange' } if (text) { - acc = [ - ...acc, - { - text, - href: filterHref(cfKey, value), - }, - ] + value = [{ text, href: filterHref(filterKey, filterValue) }] } } - return acc - }, []) + return filterKey !== 'dateTo' ? { ...acc, [filterKey]: value } : acc + }, {}) const complianceOptions: Option[] = complianceFilterOptions.map(({ text, value }) => ({ text, diff --git a/server/middleware/getPersonActivity.test.ts b/server/middleware/getPersonActivity.test.ts index 62346eb8..59c16c07 100644 --- a/server/middleware/getPersonActivity.test.ts +++ b/server/middleware/getPersonActivity.test.ts @@ -142,7 +142,7 @@ describe('/middleware/getPersonActivity', () => { ...filterVals, complianceOptions: [], errors: null, - selectedFilterItems: [], + selectedFilterItems: {}, baseUrl: '', query: { ...filterVals }, queryStr: '', diff --git a/server/views/pages/activity-log.njk b/server/views/pages/activity-log.njk index 174182df..33a4a810 100644 --- a/server/views/pages/activity-log.njk +++ b/server/views/pages/activity-log.njk @@ -1,7 +1,7 @@ {% extends "../partials/case.njk" %} {% from "govuk/components/notification-banner/macro.njk" import govukNotificationBanner %} {% from "govuk/components/pagination/macro.njk" import govukPagination %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Activity log"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Activity log" }) %} {% set currentNavSection = 'timeline' %} {% set currentSectionName = 'Activity log' %} {% set headerPersonName = personActivity.personSummary.name.forename + ' ' + personActivity.personSummary.name.surname %} @@ -109,6 +109,7 @@
  • removing filters
  • double-checking the spelling
  • removing special characters like characters and accent letters
  • +
  • using an asterisk (*) to search with a partial keyword, for example app*
  • {% endif %} diff --git a/server/views/pages/activity-log/_filters.njk b/server/views/pages/activity-log/_filters.njk index c2386192..ce479719 100644 --- a/server/views/pages/activity-log/_filters.njk +++ b/server/views/pages/activity-log/_filters.njk @@ -79,6 +79,35 @@ {% endset -%} +{% set filterCategories = [] %} +{% if filters.selectedFilterItems.keywords.length %} + {% set filterCategories = (filterCategories.push( + { + heading: { + text: 'Search term' + }, + items: filters.selectedFilterItems.keywords + }), filterCategories) %} +{% endif %} +{% if filters.selectedFilterItems.dateRange.length %} + {% set filterCategories = (filterCategories.push( + { + heading: { + text: 'Date range' + }, + items: filters.selectedFilterItems.dateRange + }), filterCategories) %} +{% endif %} +{% if filters.selectedFilterItems.compliance.length %} + {% set filterCategories = (filterCategories.push( + { + heading: { + text: 'Compliance filters' + }, + items: filters.selectedFilterItems.compliance + }), filterCategories) %} +{% endif %} +
    {{ mojFilter({ @@ -94,19 +123,14 @@ }, selectedFilters: { heading: { - html: 'Selected filters', - classes: 'govuk-heading-s' + html: 'Selected filters' }, clearLink: { text: 'Clear filters', href: '/case/' + crn + '/activity-log' }, - categories: [ - { - items: filters.selectedFilterItems - } - ] - } if filters.selectedFilterItems.length, + categories: filterCategories + } if filters.selectedFilterItems.keywords.length or filters.selectedFilterItems.dateRange.length or filters.selectedFilterItems.compliance.length, optionsHtml: filterOptionsHtml }) }} diff --git a/server/views/pages/appointments.njk b/server/views/pages/appointments.njk index 51e4c12f..efbfbf49 100644 --- a/server/views/pages/appointments.njk +++ b/server/views/pages/appointments.njk @@ -1,7 +1,7 @@ {% extends "../partials/case.njk" %} {% from "govuk/components/notification-banner/macro.njk" import govukNotificationBanner %} {% from "moj/components/button-menu/macro.njk" import mojButtonMenu %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Appointments"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Appointments" }) %} {% set currentNavSection = 'appointments' %} {% set headerPersonName = upcomingAppointments.personSummary.name.forename + ' ' + upcomingAppointments.personSummary.name.surname %} {% set headerCRN = upcomingAppointments.personSummary.crn %} diff --git a/server/views/pages/appointments/appointment.njk b/server/views/pages/appointments/appointment.njk index adaac5b6..fbeeee89 100644 --- a/server/views/pages/appointments/appointment.njk +++ b/server/views/pages/appointments/appointment.njk @@ -1,6 +1,6 @@ {% extends "../../partials/layout.njk" %} {% set appointment = personAppointment.appointment %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Appointments" if not isActivityLog else "Activity log", appointment.type] }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Appointments" if not isActivityLog else "Activity log", appointment.type] }) %} {% set extraBreadcrumb = '?' + queryParams.join('&') if queryParams.length > 0 else '' %} {% set category = '/' + category + '/' + extraBreadcrumb if category else extraBreadcrumb %} diff --git a/server/views/pages/appointments/record-an-outcome.njk b/server/views/pages/appointments/record-an-outcome.njk index 1f412248..fbda86eb 100644 --- a/server/views/pages/appointments/record-an-outcome.njk +++ b/server/views/pages/appointments/record-an-outcome.njk @@ -1,7 +1,7 @@ {% extends "../_form.njk" %} {% set headerPersonName = schedule.personSummary.name.forename + ' ' + schedule.personSummary.name.surname %} {% set title = "Which appointment are you recording an outcome for?" if actionType == "outcome" else "Which appointment?" %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Record an outcome", "Outcome"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Record an outcome", "Outcome"] }) %} {% set action = '/case/' + crn + '/record-an-outcome/' + actionType %} {% set backLink = '/case/' + crn %} {% block form %} diff --git a/server/views/pages/compliance.njk b/server/views/pages/compliance.njk index fef1c893..cd81dfa5 100644 --- a/server/views/pages/compliance.njk +++ b/server/views/pages/compliance.njk @@ -1,6 +1,6 @@ {% extends "../partials/case.njk" %} {% from "govuk/components/notification-banner/macro.njk" import govukNotificationBanner %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Compliance"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Compliance" }) %} {% set currentSectionName = 'Compliance' %} {% set currentNavSection = 'compliance' %} {% set headerPersonName = personCompliance.personSummary.name | fullName %} diff --git a/server/views/pages/interventions.njk b/server/views/pages/interventions.njk index ecd99779..ac99c390 100644 --- a/server/views/pages/interventions.njk +++ b/server/views/pages/interventions.njk @@ -1,5 +1,5 @@ {% extends "../partials/case.njk" %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Interventions"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Interventions" }) %} {% set currentNavSection = 'interventions' %} {% set currentSectionName = 'Interventions' %} {% set headerPersonName = personSummary.name.forename + ' ' + personSummary.name.surname %} diff --git a/server/views/pages/licence-condition-note.njk b/server/views/pages/licence-condition-note.njk index ff80c16b..70f97e92 100644 --- a/server/views/pages/licence-condition-note.njk +++ b/server/views/pages/licence-condition-note.njk @@ -1,5 +1,5 @@ {% extends "../partials/case.njk" %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Sentence", "Licence condition"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Sentence", "Licence condition"] }) %} {% set currentNavSection = 'sentence' %} {% set currentSectionName = 'Sentence' %} {% set headerPersonName = licenceNoteDetails.personSummary.name.forename + ' ' + licenceNoteDetails.personSummary.name.surname %} diff --git a/server/views/pages/overview.njk b/server/views/pages/overview.njk index 2519cabd..6f3c2d04 100644 --- a/server/views/pages/overview.njk +++ b/server/views/pages/overview.njk @@ -1,6 +1,6 @@ {% extends "../partials/case.njk" %} {% from "govuk/components/notification-banner/macro.njk" import govukNotificationBanner %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Overview"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Overview" }) %} {% set currentNavSection = 'overview' %} {% set currentSectionName = 'Overview' %} {% set appointmentsWithoutAnOutcomeCount = overview.appointmentsWithoutOutcome %} diff --git a/server/views/pages/personal-details.njk b/server/views/pages/personal-details.njk index db61222f..bc95fc6e 100644 --- a/server/views/pages/personal-details.njk +++ b/server/views/pages/personal-details.njk @@ -1,5 +1,5 @@ {% extends "../partials/case.njk" %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Personal details"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Personal details" }) %} {% set currentNavSection = 'personal-details' %} {% set currentSectionName = 'Personal details' %} {% set headerPersonName = personalDetails.name.forename + ' ' + personalDetails.name.surname %} diff --git a/server/views/pages/personal-details/circumstances.njk b/server/views/pages/personal-details/circumstances.njk index 43439213..4d1511db 100644 --- a/server/views/pages/personal-details/circumstances.njk +++ b/server/views/pages/personal-details/circumstances.njk @@ -1,6 +1,6 @@ {% extends "../../partials/layout.njk" %} {% set title = 'Personal circumstances' %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Personal details", "Personal circumstances"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Personal details", "Personal circumstances"] }) %} {% block beforeContent %} {{ govukBreadcrumbs({ diff --git a/server/views/pages/personal-details/contact.njk b/server/views/pages/personal-details/contact.njk index e0b04be6..5807aade 100644 --- a/server/views/pages/personal-details/contact.njk +++ b/server/views/pages/personal-details/contact.njk @@ -29,7 +29,7 @@

    - {{ personalContact.relationshipType }} + {{ personalContact.relationshipType }} {{ personalContact.name | fullName }}

    diff --git a/server/views/pages/personal-details/disabilities.njk b/server/views/pages/personal-details/disabilities.njk index d08cc7a3..28cd86a9 100644 --- a/server/views/pages/personal-details/disabilities.njk +++ b/server/views/pages/personal-details/disabilities.njk @@ -26,7 +26,7 @@ {% block pageTitle %}{{ title }}{% endblock %} {% block content %} - +

    {{title}}

    Change disability information on NDelius (opens in new tab)

    @@ -69,7 +69,7 @@ } if disability.endDate, { key: { text: "Notes" }, - value: { html: notes if notes else 'No notes' } + value: { html: notes if notes else 'No notes' } } ] }) }} diff --git a/server/views/pages/personal-details/disabilities/disability-note.njk b/server/views/pages/personal-details/disabilities/disability-note.njk index c0db660e..71895a2b 100644 --- a/server/views/pages/personal-details/disabilities/disability-note.njk +++ b/server/views/pages/personal-details/disabilities/disability-note.njk @@ -26,6 +26,7 @@ {% block pageTitle %}{{ title }}{% endblock %} {% block content %} +

    {{title}}

    Change disability information on NDelius (opens in new tab)

    diff --git a/server/views/pages/probation-history.njk b/server/views/pages/probation-history.njk index 4f1e0fff..ac6b6296 100644 --- a/server/views/pages/probation-history.njk +++ b/server/views/pages/probation-history.njk @@ -1,5 +1,5 @@ {% extends "../partials/case.njk" %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Sentence", "Probation history"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Sentence", "Probation history"] }) %} {% set currentNavSection = 'sentence' %} {% set currentSectionName = 'Sentence' %} {% set headerPersonName = sentenceDetails.personSummary.name.forename + ' ' + sentenceDetails.personSummary.name.surname %} diff --git a/server/views/pages/requirement-note.njk b/server/views/pages/requirement-note.njk index 64a28463..8b5c54f5 100644 --- a/server/views/pages/requirement-note.njk +++ b/server/views/pages/requirement-note.njk @@ -1,5 +1,5 @@ {% extends "../partials/case.njk" %} -{% set pageTitle = makePageTitle({ pageHeading: "Sentence details" }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Sentence", "Requirement"] }) %} {% set currentNavSection = 'sentence' %} {% set currentSectionName = 'Sentence' %} {% set headerPersonName = requirementNoteDetails.personSummary.name.forename + ' ' + requirementNoteDetails.personSummary.name.surname %} diff --git a/server/views/pages/risk.njk b/server/views/pages/risk.njk index bd1bfc5e..a5b6f525 100644 --- a/server/views/pages/risk.njk +++ b/server/views/pages/risk.njk @@ -6,7 +6,7 @@ {% from "../_components/predictor-score/macro.njk" import predictorScore %} {% from "../_components/predictor-timeline-item/macro.njk" import predictorTimelineItem %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact" ,"Risk"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Risk" }) %} {% set currentNavSection = 'risk' %} {% set currentSectionName = 'Risk' %} {% set headerPersonName = personRisk.personSummary.name | fullName %} @@ -14,17 +14,17 @@ {% set headerDob = personRisk.personSummary.dateOfBirth %} {% set headerGender = personRisk.personSummary.gender %} {% set hasRiskAssessment = risks.assessedOn %} -{% set highScoring = groupNeeds("SEVERE", needs.identifiedNeeds) %} -{% set lowScoring = groupNeeds("STANDARD", needs.identifiedNeeds) %} +{% set severeScoring = groupNeeds("SEVERE", needs.identifiedNeeds) %} +{% set standardScoring = groupNeeds("STANDARD", needs.identifiedNeeds) %} {% set withoutScore = needs.notIdentifiedNeeds %} {% if risks.assessedOn %} {% set lastUpdatedDate = 'Last updated (OASys):' + risks.assessedOn | dateWithYear %} {% endif %} -{% set highScoringNeeds %} - {% if highScoring.length > 0 %} +{% set severeScoringNeeds %} + {% if severeScoring.length > 0 %}
      - {% for need in highScoring %} + {% for need in severeScoring %}
    • {{ need.name }}
    • @@ -35,10 +35,10 @@ {% endif %} {% endset %} -{% set lowScoringNeeds %} - {% if lowScoring.length > 0 %} +{% set standardScoringNeeds %} + {% if standardScoring.length > 0 %}
        - {% for need in lowScoring %} + {% for need in standardScoring %}
      • {{ need.name }}
      • @@ -93,12 +93,12 @@ {{ govukSummaryList({ rows: [ { - key: { html: 'High-scoring areas from the assessment' }, - value: { html: '' + highScoringNeeds + '' } + key: { html: 'Severe' }, + value: { html: '' + severeScoringNeeds + '' } }, { - key: { html: 'Low-scoring areas from the assessment' }, - value: { html: '' + lowScoringNeeds + ''} + key: { html: 'Standard' }, + value: { html: '' + standardScoringNeeds + ''} }, { key: { html: 'Areas without a need score' }, diff --git a/server/views/pages/sentence.njk b/server/views/pages/sentence.njk index e365db46..c5113d7e 100644 --- a/server/views/pages/sentence.njk +++ b/server/views/pages/sentence.njk @@ -1,5 +1,5 @@ {% extends "../partials/case.njk" %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Sentence"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: "Sentence" }) %} {% set currentNavSection = 'sentence' %} {% set currentSectionName = 'Sentence' %} {% set headerPersonName = sentenceDetails.personSummary.name.forename + ' ' + sentenceDetails.personSummary.name.surname %} diff --git a/server/views/pages/sentence/offences.njk b/server/views/pages/sentence/offences.njk index 0c219f6e..4504629e 100644 --- a/server/views/pages/sentence/offences.njk +++ b/server/views/pages/sentence/offences.njk @@ -1,7 +1,7 @@ {% extends "../../partials/layout.njk" %} {% set title = 'Offences' %} {% set headerPersonName = offences.name.forename + ' ' + offences.name.surname %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Sentence", "Offences"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Sentence", "Offences"] }) %} {% block beforeContent %} {{ govukBreadcrumbs({ items: [ diff --git a/server/views/pages/sentence/previous-orders.njk b/server/views/pages/sentence/previous-orders.njk index 699b96d1..51931efa 100644 --- a/server/views/pages/sentence/previous-orders.njk +++ b/server/views/pages/sentence/previous-orders.njk @@ -1,6 +1,6 @@ {% extends "../../partials/layout.njk" %} {% set headerPersonName = previousOrderHistory.name.forename + ' ' + previousOrderHistory.name.surname %} -{% set pageTitle = makePageTitle({ pageHeading: ["Contact", "Sentence", "Previous orders"] }) %} +{% set pageTitle = makePageTitle({ pageHeading: ["Sentence", "Previous orders"] }) %} {% block beforeContent %} {{ govukBreadcrumbs({