Merge pull request #7 from Mindsers/develop

Be ready for github

Author: mindsers

.gitlab-ci.yml

@@ -0,0 +1,10 @@
+language: node_js
+node_js:
+  - "6"
+
+install:
+  - npm install
+
+script:
+  - npm run test:lint
+  - npm test

.travis.yml

@@ -0,0 +1,19 @@
+# How to contribute
+
+We love contributions from everyone if they take care of this contribution guide.
+
+## Issue
+
+Before submiting an issue, please be sure there not exist.
+
+## Code change
+
+To contribute in code base:
+
+1. fork the project
+2. make your changes in a new branch
+3. write test for your changes
+4. submit a pull request
+
+Pull request will only be merged if modified code respect eslint configuration (standardjs with some changes)
+and test coverage doesn't fall.

CONTRIBUTING.md

@@ -2,7 +2,8 @@
 
 [![build status][badge_build_status_image]][badge_build_status_link]
 [![standardjs style][badge_js_code_style_image]][badge_js_code_style_link]
-[![coverage report][badge_coverage_report_image]][badge_coverage_report_link]
+[![coverage status][badge_coverage_report_image]][badge_coverage_report_link]
+[![MIT license][badge_license_image]][badge_license_link]
 
 Nativetable is a simple native es6 module to create and work with dynamics HTML tables.
 
@@ -68,6 +69,10 @@ let ntable = new Nativetable('tableid', {
 });
 ```
 
+## Contribution
+
+To contribute to this repo please follow the [contribution guide](https://github.com/Mindsers/nativetable/blob/master/CONTRIBUTING.md).
+
 ## License
 
 This project is under the MIT License. (see LICENSE file in the root directory)
@@ -97,9 +102,11 @@ This project is under the MIT License. (see LICENSE file in the root directory)
 [wiki]: https://git.nathanaelcherrier.com/mindsers/nativetable/wikis/home
 [project]: https://git.nathanaelcherrier.com/mindsers/nativetable
 
-[badge_build_status_image]: https://git.nathanaelcherrier.com/mindsers/nativetable/badges/master/build.svg
-[badge_build_status_link]: https://git.nathanaelcherrier.com/mindsers/nativetable/commits/master
+[badge_build_status_image]: https://img.shields.io/travis/Mindsers/nativetable/master.svg
+[badge_build_status_link]: https://travis-ci.org/Mindsers/nativetable
 [badge_js_code_style_image]: https://img.shields.io/badge/code%20style-standard-yellow.svg
 [badge_js_code_style_link]: http://standardjs.com
-[badge_coverage_report_image]: https://git.nathanaelcherrier.com/mindsers/nativetable/badges/master/coverage.svg
-[badge_coverage_report_link]: https://git.nathanaelcherrier.com/mindsers/nativetable/commits/master
+[badge_license_image]: https://img.shields.io/badge/license-MIT-blue.svg
+[badge_license_link]: https://github.com/Mindsers/nativetable/blob/master/LICENSE
+[badge_coverage_report_image]: https://img.shields.io/coveralls/Mindsers/nativetable/master.svg
+[badge_coverage_report_link]: https://coveralls.io/github/Mindsers/nativetable

README.md

@@ -10,10 +10,12 @@
     "build:dev": "NODE_ENV=development npm run build:clean && npm run build:js -- --sourcemap -w",
     "build:prod": "NODE_ENV=production npm run build:clean && npm run build:js",
     "build": "npm run build:prod",
+    "test:coveralls": "npm run test:coverage && nyc report --reporter=text-lcov | coveralls",
     "test:coverage": "NODE_ENV=test nyc mocha",
     "test:unit": "mocha -r babel-core/register",
+    "test:lint": "eslint ./src",
     "test:clean": "rm -rf coverage",
-    "test": "npm run test:clean && npm run test:coverage"
+    "test": "npm run test:clean && npm run test:coveralls"
   },
   "keywords": [
     "table",
@@ -27,11 +29,13 @@
     "babel-register": "^6.16.3",
     "chai": "^3.5.0",
     "chai-spies": "^0.7.1",
+    "coveralls": "^2.11.15",
     "eslint": "^3.7.1",
     "eslint-config-standard": "^6.2.0",
     "eslint-plugin-promise": "^3.0.0",
     "eslint-plugin-standard": "^2.0.1",
     "mocha": "^3.1.2",
+    "mocha-lcov-reporter": "^1.2.0",
     "nyc": "^8.3.2",
     "rollup": "^0.36.3",
     "rollup-plugin-babel": "^2.6.1",

package.json

@@ -135,6 +135,8 @@ describe('Nativetable', () => {
             }
           }
         }
+
+        nt.filtered
       }
 
       test.should.not.throw()
@@ -294,6 +296,43 @@ describe('Nativetable', () => {
       nt.sorted.should.be.deep.equal(nt.filtered)
     })
 
+    it('should return last sorting when options.reloading.sorted is false', () => {
+      let expected = [
+        { id: 12, name: 'bjob', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'boab', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bob', lastname: 'ronb', age: 81, man: true },
+        { id: 12, name: 'bobg', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bodb', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bodjb', lastname: 'rfob', age: 81, man: true },
+        { id: 12, name: 'bofgb', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bokb', lastname: 'rokb', age: 81, man: true },
+        { id: 12, name: 'bosb', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'botb', lastname: 'riob', age: 81, man: true },
+        { id: 12, name: 'boub', lastname: 'rbob', age: 81, man: true },
+        { id: 12, name: 'bovb', lastname: 'rorb', age: 81, man: true },
+        { id: 12, name: 'boxb', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bpob', lastname: 'rob', age: 81, man: true }
+      ]
+
+      let falseFiltered = [
+        { id: 12, name: 'bjob', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'boab', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bob', lastname: 'ronb', age: 81, man: true },
+        { id: 12, name: 'bobg', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bodb', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'botb', lastname: 'riob', age: 81, man: true },
+        { id: 12, name: 'boub', lastname: 'rbob', age: 81, man: true },
+        { id: 12, name: 'bovb', lastname: 'rorb', age: 81, man: true },
+        { id: 12, name: 'boxb', lastname: 'rob', age: 81, man: true },
+        { id: 12, name: 'bpob', lastname: 'rob', age: 81, man: true }
+      ]
+
+      nt.sorted // first call / adding relsult to cache
+      nt.sources = falseFiltered
+      nt.options.reloading.sorted = false
+      nt.sorted.should.be.deep.equal(expected)
+    })
+
     it('should return ASC sorted sources', () => {
       let expected = [
         { id: 12, name: 'bjob', lastname: 'rob', age: 81, man: true },