Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Planner] wrong plan if TS model with = date filter #328

Closed
StpMax opened this issue Nov 23, 2023 · 2 comments · Fixed by #335
Closed

[Planner] wrong plan if TS model with = date filter #328

StpMax opened this issue Nov 23, 2023 · 2 comments · Fixed by #335
Assignees
Labels
bug Something isn't working

Comments

@StpMax
Copy link
Contributor

StpMax commented Nov 23, 2023

If have TS model and do query:

select *
from data as t join model as m
            where t.date = '2024-06-26';

then plan will be like

  1. [correct] FetchDataframeStep: select distinct groups
  2. [wrong] MapReduceStep: str(steps[1].step.query) =
SELECT * FROM data AS t WHERE (((t.date = '2024-06-26')) AND (t.date IS NOT NULL)) AND (t.customerid = '$var[customerid]') ORDER BY t.date DESC
  1. [wrong] ApplyTimeseriesPredictorStep: output_time_filter = t.date = '2024-06-26'
    According to this doc, at step №2 should be selected window count rows before the date. At step №3 should be appyed filter date > '2024-06-26' (or >=?)
@StpMax StpMax added the bug Something isn't working label Nov 23, 2023
@akshithagunupati
Copy link

Hi @StpMax can I work on this?

@StpMax
Copy link
Contributor Author

StpMax commented Dec 4, 2023

Let ask @ea-rus about it, he manage the repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants