Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support predict params in [select from join where] cases #285

Closed
paxcema opened this issue Aug 18, 2023 · 4 comments
Closed

Support predict params in [select from join where] cases #285

paxcema opened this issue Aug 18, 2023 · 4 comments

Comments

@paxcema
Copy link
Contributor

paxcema commented Aug 18, 2023

The USING parameters are failing to be included in the plan for queries like this one:

SELECT m.symbol, m.open_time, m.open_price, m.confidence, m.lower, m.upper
FROM binance_view as t
JOIN timegpt_binance as m
WHERE t.open_time > LATEST
USING
validate_token = True;

The expected behavior is to find validate_token = True in the prediction parameters field.

@paxcema
Copy link
Contributor Author

paxcema commented Aug 18, 2023

Instructions for replicating can be found here, but do note you need to pass the api_key param at ML engine creation.

@paxcema
Copy link
Contributor Author

paxcema commented Aug 24, 2023

FYI @tomhuds this is important for enabling predict-time dynamic arguments in TimeGPT's current design. Users can still define any parameter they wish at creation time, though.

We should clarify with Andrey how big a task this is (looked at the code base just now, and I suspect it is not trivial) before commiting to it.

It's probably best to tackle this via the new syntax anyway.

@tomhuds
Copy link
Contributor

tomhuds commented Aug 24, 2023

+1 for fixing alongside the new CREATE FORECASTING MODEL refactor

@ea-rus
Copy link
Contributor

ea-rus commented Sep 25, 2023

fixed in #293

@ea-rus ea-rus closed this as completed Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants