Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Upload BYOM files' method from python SDK #76

Closed
tomhuds opened this issue Oct 4, 2023 · 1 comment · Fixed by #91
Closed

'Upload BYOM files' method from python SDK #76

tomhuds opened this issue Oct 4, 2023 · 1 comment · Fixed by #91
Assignees
Labels
enhancement New feature or request

Comments

@tomhuds
Copy link
Contributor

tomhuds commented Oct 4, 2023

e.g.

def upload_byom(model_name: str, model_file: str, requirements_file: str)
Will require an update to our byom upload endpoint

@tomhuds tomhuds changed the title Upload BYOM method from python sdk 'Upload BYOM files' method from python SDK Oct 4, 2023
@tomhuds tomhuds transferred this issue from mindsdb/mindsdb Oct 4, 2023
@ea-rus
Copy link
Contributor

ea-rus commented Oct 5, 2023

byom upload creates the new ml engine

Maybe is better to:

byom_engine = con.ml_engines.create_byom(model_code: str, requirements_code: str)

or

byom_engine = con.ml_engines.create_byom(path_to_model_code: str, path_to_model_requirements: str)

Also we can try to implement option to extract code and requirements from module

byom_engine = con.ml_engines.create_byom(<imported python module or class>)

@tomhuds tomhuds added the enhancement New feature or request label Oct 17, 2023
ea-rus added a commit that referenced this issue Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants