added upload file #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quest-bot loot #81 |
|
setohe0909
approved these changes
Nov 6, 2024
Better-Boy
reviewed
Nov 7, 2024
| override async uploadFile(filePath: string, tableName: string, integration: string): Promise<void> { | ||
| const fileName = path.basename(filePath); | ||
|
|
||
| const sqlQuery = ` |
There was a problem hiding this comment.
@setohe0909 Does this query actually upload the file from local? Shouldn't we use multipart upload?
|
@IshuSinghSE closing this PR as it's been 5 days and there has been no response in making changes as per @Better-Boy's comments |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #81