Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release.yml #1127

Closed
paxcema opened this issue Mar 16, 2023 · 5 comments
Closed

Improve release.yml #1127

paxcema opened this issue Mar 16, 2023 · 5 comments
Assignees
Labels
Community Community-led efforts enhancement New feature or request help wanted Extra attention is needed

Comments

@paxcema
Copy link
Contributor

paxcema commented Mar 16, 2023

Right now this file is helpful to trigger releases into PyPI when they come from a branch other than stable or staging, which is very useful for updating old versions without messing up those two branches.

However, when the release comes from those two branches, I'm fairly certain a duplicate PyPI release job is triggered, by sequentially running lightwood.yml first, then release.yml.

We should modify one of them so that this duplicate procedure is avoided.

@paxcema paxcema added enhancement New feature or request help wanted Extra attention is needed Community Community-led efforts labels Mar 16, 2023
@tomhuds tomhuds assigned StpMax and unassigned StpMax Mar 18, 2023
@ddninja
Copy link

ddninja commented Oct 23, 2023

Hi @paxcema , I would like to work on this.
I will suggest to remove the PyPI release job from lightwood.yml

@paxcema
Copy link
Contributor Author

paxcema commented Oct 23, 2023

Hi @ddninja, sure.

How about merging release.yml logic into lightwood.yml so that all deployment-related jobs are here?

We only want to avoid duplicate runs, the problem with your approach above is that we do want to deploy in PyPI when pushing to stable.

@ddninja
Copy link

ddninja commented Oct 24, 2023

@paxcema If we merge release.yml logic into lightwood.yml, the test job will also be executed if the release is published.
If this is expected behaviour then I will do that, also once we merge these file , release.yml will not be needed any more.
Or do you want to run test job only if build is pushed to stable/staging branch.

@ddninja
Copy link

ddninja commented Oct 27, 2023

@paxcema i have raised a pull request. can you please check.

@paxcema
Copy link
Contributor Author

paxcema commented Jan 22, 2024

Closed via #1196, thanks @ddninja!

@paxcema paxcema closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Community-led efforts enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants