MBX-3720: Modify linter rules (#134)

Author: sergeysozinov

.github/workflows/analyze_and_test.yml

@@ -65,7 +65,22 @@ jobs:
       - run: cd mindbox_ios && flutter pub get
       - run: cd mindbox_ios && flutter analyze
       - run: cd mindbox_ios && flutter test
-   
+
+  example_flutter_test:
+    name: example running analyze
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-java@v1
+        with:
+          java-version: "12.x"
+      - uses: subosito/flutter-action@v2
+        with:
+          channel: "stable"
+
+      - name: lint example
+        run: cd example/flutter_example && flutter pub get && flutter analyze
+
   plugin_flutter_test:
     name:  plugin running analyze and tests
     runs-on: ubuntu-latest
@@ -77,7 +92,10 @@ jobs:
       - uses: subosito/flutter-action@v2
         with:
           channel: "stable"
-          
+
+      - name: lint example
+        run: cd example/flutter_example && flutter pub get && flutter analyze
+
       - name: Add publish_to tag in mindbox_android
         run: |
          cd mindbox_android && echo "publish_to: 'none'" | cat - pubspec.yaml > temp && mv temp pubspec.yaml

example/flutter_example/analysis_options.yaml

@@ -1,28 +1,31 @@
-# This file configures the analyzer, which statically analyzes Dart code to
-# check for errors, warnings, and lints.
-#
-# The issues identified by the analyzer are surfaced in the UI of Dart-enabled
-# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be
-# invoked from the command line by running `flutter analyze`.
-
-# The following line activates a set of recommended lints for Flutter apps,
-# packages, and plugins designed to encourage good coding practices.
 include: package:flutter_lints/flutter.yaml
 
 linter:
-  # The lint rules applied to this project can be customized in the
-  # section below to disable rules from the `package:flutter_lints/flutter.yaml`
-  # included above or to enable additional rules. A list of all available lints
-  # and their documentation is published at https://dart.dev/lints.
-  #
-  # Instead of disabling a lint rule for the entire project in the
-  # section below, it can also be suppressed for a single line of code
-  # or a specific dart file by using the `// ignore: name_of_lint` and
-  # `// ignore_for_file: name_of_lint` syntax on the line or in the file
-  # producing the lint.
   rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
+    file_names: false
+    avoid_print: false
+    lines_longer_than_80_chars: false
+    cancel_subscriptions: true
+    constant_identifier_names: true
+    directives_ordering: false
+    empty_constructor_bodies: true
+    flutter_style_todos: true
+    implementation_imports: true
+    package_names: true
+    package_prefixed_library_names: true
+    prefer_final_locals: true
+    sort_child_properties_last: true
+    sort_constructors_first: true
+    sort_unnamed_constructors_first: true
+    type_annotate_public_apis: false
+    unnecessary_await_in_return: true
+    prefer_is_not_empty: true
+    avoid_empty_else: true
+    avoid_returning_null_for_void: true
+    no_duplicate_case_values: true
+    prefer_typing_uninitialized_variables: true
+    public_member_api_docs: false
+    always_put_control_body_on_new_line: true
+    curly_braces_in_flow_control_structures: true
 
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+# See lint rules here https://dart.dev/tools/linter-rules#lints

example/flutter_example/android/app/build.gradle

@@ -27,7 +27,7 @@ if (flutterVersionName == null) {
 android {
     namespace "cloud.mindbox.flutter_example"
     compileSdk flutter.compileSdkVersion
-    ndkVersion flutter.ndkVersion
+    ndkVersion "26.1.10909125"
 
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8

example/flutter_example/android/build.gradle

@@ -1,13 +1,13 @@
 buildscript {
-    ext.kotlin_version = '1.8.0'
+    ext.kotlin_version = '1.9.22'
     repositories {
         google()
         mavenCentral()
         maven {url 'https://developer.huawei.com/repo/'}
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.6.0'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
         classpath 'com.google.gms:google-services:4.4.0'
         classpath 'com.huawei.agconnect:agcp:1.6.0.300'
@@ -25,6 +25,16 @@ allprojects {
 rootProject.buildDir = '../build'
 subprojects {
     project.buildDir = "${rootProject.buildDir}/${project.name}"
+    afterEvaluate {
+        if (it.hasProperty('android')) {
+            if (it.android.namespace == null) {
+                def manifest = new XmlSlurper().parse(file(it.android.sourceSets.main.manifest.srcFile))
+                def packageName = manifest.@package.text()
+                println("Setting ${packageName} as android namespace")
+                android.namespace = packageName
+            }
+        }
+    }
     project.evaluationDependsOn(':app')
 }
 

example/flutter_example/android/gradle.properties

@@ -1,3 +1,4 @@
 org.gradle.jvmargs=-Xmx4G
 android.useAndroidX=true
 android.enableJetifier=true
+apmsInstrumentationEnabled=false

example/flutter_example/android/gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip

example/flutter_example/android/settings.gradle

@@ -20,8 +20,8 @@ pluginManagement {
 
 plugins {
     id "dev.flutter.flutter-plugin-loader" version "1.0.0"
-    id "com.android.application" version '7.4.2' apply false
-    id "org.jetbrains.kotlin.android" version "1.7.10" apply false
+    id "com.android.application" version '8.6.0' apply false
+    id "org.jetbrains.kotlin.android" version "1.9.22" apply false
 }
 
 include ":app"

example/flutter_example/lib/models/list_item.dart

@@ -1,9 +1,4 @@
 class ListItem {
-  final String uniqueKey;
-  final String title;
-  final String description;
-  final String imageUrl;
-  final String pushLink;
 
   ListItem({
     required this.uniqueKey,
@@ -12,4 +7,9 @@ class ListItem {
     required this.imageUrl,
     required this.pushLink,
   });
+  final String uniqueKey;
+  final String title;
+  final String description;
+  final String imageUrl;
+  final String pushLink;
 }

example/flutter_example/lib/models/mindbox_remote_message.dart

@@ -4,13 +4,6 @@ import 'payload.dart';
 
 //example of data by push
 class MindboxRemoteMessage {
-  final String uniqueKey;
-  final String title;
-  final String description;
-  final String? pushLink;
-  final String? imageUrl;
-  final List<PushAction> pushActions;
-  final String? payload;
 
   MindboxRemoteMessage({
     required this.uniqueKey,
@@ -23,8 +16,8 @@ class MindboxRemoteMessage {
   });
 
   factory MindboxRemoteMessage.fromJson(Map<String, dynamic> json) {
-    var pushActionsFromJson = json['pushActions'] as List;
-    List<PushAction> pushActionsList = pushActionsFromJson.map((action) => PushAction.fromJson(action)).toList();
+    final pushActionsFromJson = json['pushActions'] as List;
+    final List<PushAction> pushActionsList = pushActionsFromJson.map((action) => PushAction.fromJson(action)).toList();
 
     return MindboxRemoteMessage(
       uniqueKey: json['uniqueKey'],
@@ -36,10 +29,18 @@ class MindboxRemoteMessage {
       payload: json['payload'],
     );
   }
+  final String uniqueKey;
+  final String title;
+  final String description;
+  final String? pushLink;
+  final String? imageUrl;
+  final List<PushAction> pushActions;
+  final String? payload;
 
   Payload? getPayloadObject() {
-    if (payload == null) return null;
-    Map<String, dynamic> payloadMap = jsonDecode(payload!);
+    if (payload == null)
+      { return null; }
+    final Map<String, dynamic> payloadMap = jsonDecode(payload!);
     return Payload.fromJson(payloadMap);
   }
 }

example/flutter_example/lib/models/payload.dart

@@ -4,8 +4,6 @@
                         "pushDate":"<Push date>"
                       }*/
 class Payload {
-  final String pushName;
-  final String pushDate;
 
   Payload({required this.pushName, required this.pushDate});
 
@@ -15,6 +13,8 @@ class Payload {
       pushDate: json['pushDate'],
     );
   }
+  final String pushName;
+  final String pushDate;
 
   Map<String, dynamic> toJson() {
     return {