Replies: 2 comments
-
Did a little more digging, the underlying |
Beta Was this translation helpful? Give feedback.
-
Would be nice with some tests for smart cut indeed, but I haven't had time for that. And I haven't really found any fix to the problems that people are having with smart cut, so it's hard to make a good test when I don't know how to implement the actual code to test. Smart cut as it's currently implemented is quite simple. It will just re-encode the part of the segment before the keyframe, and then concat it with the rest of the segment, however as evident, this does not always work perfectly. |
Beta Was this translation helpful? Give feedback.
-
README.md#features (in reference to "smart cut") points to #126. Some stats re: #126:
There is also issues.md#smart-cut-not-working.
As I was pulling these threads together, I began to feel that I had a decent picture of the current status, but maybe some dates could be added to #126's issue description? I didn't realize at first that it had been kept reasonably up-to-date, until I checked the edit history. If someone makes the same mistake I did: skimming through the 68 comments to ascertain the current status is a bit daunting.
I was planning to suggest closing #126 & opening a new issue, just to "reboot" the conversation and make it a little easier to navigate, but now not sure that would be helpful.
Re: #126's issue description:
I haven't had any luck using "smart cut" with
webm
(from YouTube), might be nice to explicitly mention formats known not to work. I can obtain and try some morewebm
samples to solidify the "not working" status, maybe from https://github.com/mifi/lossless-cut-fixtures, or elsewhere. Here is the output fromffmpeg -i foo.webm
:Testing
Hmm, I was thinking about testing around "smart cut", looks likes tests aren't currently run as part of the build process, and I don't see any (recent-ish) issues or discussions re: status of testing, might be helpful to have a stub for that. I see the move to vitest 🚀 commit, which is exciting!
Beta Was this translation helpful? Give feedback.
All reactions