Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying on Heroku #387

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Deploying on Heroku #387

wants to merge 34 commits into from

Conversation

1v4n4
Copy link
Member

@1v4n4 1v4n4 commented Jun 22, 2021

We deployed our project on Heroku at this link https://evening-earth-80698.herokuapp.com/users/sign_in. In Readme, on a master branch should be two links for Heroku, in the Live demo and Deployment section. We deployed from the master branch and merged everything previously

Copy link

@SajjadAhmad14 SajjadAhmad14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Required ♻️

"Change is inevitable. Change is constant. -Benjamin Disraeli"

Hello, you have been doing a tremendous job so far 👌

To Highlight 🎉

  • PR title and summary are descriptive.

To Improve 🙏

  • Link to Heroku in README file should be added. There is no link to the live demo in the README file of the master branch. Please see this screenshot.
  • Project does not have a development branch. You should have followed Git flow already in previous milestones. You should already have merged a pull request from development to the master branch.

Happy Coding ☺️

If you have any questions you can comment here in this PR or can always connect with me on slack ( @sajjad Ahmad ).

Copy link

@george-shammar george-shammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: CHANGES REQUIRED ♻️ ♻️ 🚧

Highlight
You have deployed application and it's available online. Good job. 👍 👏

Please see the required changes below:

  • The link to the live version of the application needs to be in your README. The "Live Demo" and "Deployment" sections in your README is empty with no link.

[OPTIONAL]

  • You have no development branch. I'm confused as to how that is possible seeing this is the last milestone for this project.
  • Github action is also not properly set up.

The optional changes are being made optional just because you've passed the milestones where it was enforced but I strongly recommend you fix it now.

Please submit another CRR when you're ready.

Cheers and happy coding. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants