Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Inline Value truncation + hover (both debugger and notebooks) #241792

Open
2 tasks
Yoyokrazy opened this issue Feb 25, 2025 · 0 comments
Open
2 tasks

Test: Inline Value truncation + hover (both debugger and notebooks) #241792

Yoyokrazy opened this issue Feb 25, 2025 · 0 comments
Assignees
Milestone

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Feb 25, 2025

Refs: #239259

Complexity: 3

author: @Yoyokrazy

Create Issue


Summary

Inline value decorations now have length truncation based on the viewport, and have a rich hover to compensate for more aggressive data trimming.

note: copilot edits support for notebooks has just been added, and we are looking for as much selfhosting as possible. Throughout this and other TPI's the notebook team would appreciate if you generated edits + notebooks as much as possible, before using pre made notebooks you already have. There are some rough edges, so don't feel the need to get stuck on this part.

Steps to Test:

Part Notebook:

  • Change the setting notebook.inlineValues to on or auto. Setting this to auto will only run when a language provider for inline values is registered (ie pylance if you want to test that), whereas on will fall back to a less language aware regex strategy.
  • Build a notebook (with edits maybe 👀) and execute several cells, checking their inline values for truncation length, and the hover content/formatting.

Part Debugger:

  • Change the setting debug.inlineValues explicitly to on. Setting this to auto will only run when a language provider for inline values is registered for the given language, whereas on will fall back to a less language aware regex strategy.
  • Debug any code with breakpoints, and ensure you see inline values styled with the debugger rules (yellow coloring, different opacity, etc). Inspect the hovers to make sure that the content is styled correctly and is readable.

Known issues:

  • when hovering over an inline value decoration, the editor hover has a tendency to pick up the language hovers for that line as well. As a specific example, this can be seen with git blame decorations and typescript, if you end a line without a semicolon and happen to have a literal at the end of the line. Additionally, in python cells, there can be extremely verbose data type manual pages that you have to scroll past to get to the inline value hover content.
    • need to investigate either how to A: promote value hovers to the top maybe, or B: only pick up the decoration hover, rather than the other symbols on the line. cc/ @aiday-mar for potentially some editor-hover related pointers. These decorations currently use the hoverMessage property on the IModelDeltaDecoration object.

cursor at the red line on the inline value, see the depth of the scroll bar within the hover widget.
Image


Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants