Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Omitting attachments in chat #241777

Open
3 tasks
justschen opened this issue Feb 24, 2025 · 0 comments
Open
3 tasks

Test: Omitting attachments in chat #241777

justschen opened this issue Feb 24, 2025 · 0 comments
Assignees
Milestone

Comments

@justschen
Copy link
Contributor

justschen commented Feb 24, 2025

Refs: #240024 and #240027

Complexity: 2

Create Issue


This iteration includes many improvements to vision in chat. One of these includes the omission warning for files that are generally not valid in chat. This includes SVG, PDFs, MOVs, MP4s, MP3s, etc - anything that is not a "text document". This warning will be shown in the chat input and also in the chat context attachments after submitting.
 

Sanity testing section

  1. Attach some files that might not be valid. Examples include SVG, PDFs, MOVs, MP4s, MP3s, or any non-supported image type (HEIC, CR2, etc).
  2. Note that there should be warnings and hovering over it will show a warning reason.
  3. After submitting, warnings should also be shown.
  4. Note that in the case of attaching files that CAN be attached, sometimes they will be limited by context window limitations if they are too large (ie, an extension data MD file like below) and the attachment will not be crossed out or show a warning until after submitting.
  5. Try attaching an image that is over 30mb. There should be a notification that the image was too large to be processed.
  6. History for images should also work in this scenario!

extensionData_2025-02-23_22-24-25.md

General notes

  1. Feel free to try a bunch of differnt file types and see what is expected or not expected!
  2. Remember that for now, images only work in GPT4o for regular users (Claude and Gemini should work for dual accessed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants