Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+C/Ctrl+V on empty selection no longer duplicates line #241164

Open
bpasero opened this issue Feb 19, 2025 · 7 comments · May be fixed by #241764
Open

Ctrl+C/Ctrl+V on empty selection no longer duplicates line #241164

bpasero opened this issue Feb 19, 2025 · 7 comments · May be fixed by #241764
Assignees
@mjbvz @aiday-mar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority papercut 🩸 A particularly annoying issue impacting someone on the team regression Something that used to work is now broken
Milestone
February 2025

Comments

@bpasero
Copy link
Member

bpasero commented Feb 19, 2025

Steps to Reproduce:

  1. open https://github.com/microsoft/vscode/blob/6600b07e5c619c98bf1cdb2984c3f5f901fc9952/extensions/vscode-api-tests/src/singlefolder-tests/workspace.fs.test.ts#L269
  2. click into the strictEqual somewhere without selecting
  3. Ctrl+C/Ctrl+V

=> 🐛

Image

Bisect: fe4d6a8...2ef2dbd
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority papercut 🩸 A particularly annoying issue impacting someone on the team regression Something that used to work is now broken labels Feb 19, 2025
@aiday-mar
Copy link
Contributor

Hi thank you for filing this issue. I tested on the given file and the given commit. The pasted text looks correct? I am not sure if I quite understood the issue.

Screen.Recording.2025-02-19.at.09.43.32.mov

@0x78f1935
Copy link

I don't know why,.. but I just drop this here.

#240127

What is happening with copy/paste??? It's messed up since 1.97.0...

@aiday-mar
Copy link
Contributor

Hi @0x78f1935 thank you for filing this issue. I am not sure if these are related as in your case, you are copying from the debug hover, the current issue is about the core editor. Thank you for letting me know however!

@0x78f1935
Copy link

Hi @aiday-mar , No problem! I have seen more issues about copy paste in various sections, especially after 1.97.0. I'm also not sure if those are related but it definitely stands out that there is an issue with how copy/paste is being handled within VSC after 1.97.0.

@bpasero
Copy link
Member Author

bpasero commented Feb 19, 2025

@aiday-mar the bug is that with empty selection the line should duplicate and not break in the middle.

@bpasero
Copy link
Member Author

bpasero commented Feb 19, 2025

Caused by ae77c3f

@mjbvz mjbvz mentioned this issue Feb 19, 2025
Closed
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 19, 2025

I can only repo in large projects. I suspect this is timing related. ae77c3f makes it so that you can hit this issue more often if TS is slow, but it could have happened before too

Looking into a fix

mjbvz added a commit to mjbvz/vscode that referenced this issue Feb 24, 2025
@mjbvz
Preserve original data transfer value if still in same ext host context
4fb6e4a 
Fixes microsoft#241164
@mjbvz mjbvz linked a pull request Feb 24, 2025 that will close this issue
Open
@mjbvz mjbvz added this to the February 2025 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

@aiday-mar aiday-mar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority papercut 🩸 A particularly annoying issue impacting someone on the team regression Something that used to work is now broken
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

Preserve original data transfer value if still in same ext host context mjbvz/vscode
4 participants
@bpasero @mjbvz @0x78f1935 @aiday-mar