Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal suggest: Request completion sequence breaks when PSReadLine is disabled, clarify whether we enable PSReadLine for screen readers #241759

Open
Tyriar opened this issue Feb 24, 2025 · 0 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 24, 2025

Repro:

  1. Windows
  2. Enable NVDA
  3. Enable terminal suggest
  4. Ensure shell integration is not loading PSReadLine
  5. Type echo a, 🐛 es keep repeating
    Image

Right now the intent was for PSReadLine not to be loaded but it was being loaded by module auto loading due to this line:

$ContinuationPrompt = (Get-PSReadLineOption).ContinuationPrompt

When we fix that, we need to either:

  • always import PSReadLine explicitly before it's used, this would get 633;E to light up for screen reader users, or
  • ensure we never send this request completions sequence when PSReadLine is not loaded.

Additionally we should prevent the possibility of getting into a loop like this, I'm not sure why that's happening

@Tyriar Tyriar added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration labels Feb 24, 2025
@Tyriar Tyriar added this to the March 2025 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration
Projects
None yet
Development

No branches or pull requests

2 participants