-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove overflow menu for Open Editors panel #241025
Comments
The overflow menu does not repeat buttons that are already there. Rather, it is a place that first-class actions can be demoted to, and a place where actions not considered first-class can be accessed. For the alignment issue I propose that a "..." menu gets added to the title bar of the Explorer view. It could start off by having an option that gets to Settings editor with a set of relevant settings (the |
See also #240073 |
Looks like this is from #237678 I know I approved that PR, but I see the downside of the additional "...". I am not sure the addition of the configuration discoverability justifies for this. In the end, we have countless of UI parts that are all configurable (including the explorer) where we do not show a specific action to jump to configuration, so in terms of UX we are very inconsistent. //cc @benibenj |
/duplicate #240073 |
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines. Happy Coding! |
Ok fair enough, but the action of removing a button for the sake of a clean UI, and not having buttons I don't need, does not merit adding an overflow menu. I want an action gone, not moved. The right click menu can be used to get an action back.
Hard pass on that. I don't want a whole array of |
I'm hoping that my PR #241268 to resolve this will be accepted. |
I would like to be able to remove this button:
I think it's newly added, but I'm not totally sure.
Either way, I want the "close all" button (next to it) to be vertically aligned with the "collapse all" button from the workspaces panel.
I use these two buttons oftenly in quick succession to "clean" my workspace before starting on a new task, like this:
Apart from my particular use-case, it doesn't make sense to me that one panel has an overflow menu, and another panel (with MORE actions), doesn't. But at the same time, I feel like definitely not everything needs an overflow menu, so we can also just remove them for all panels. After all, the options therein are not really earth shattering, are they. They are merely a repeat of the button that are already there.
The text was updated successfully, but these errors were encountered: