Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overflow menu for Open Editors panel #241025

Closed
thany opened this issue Feb 17, 2025 · 7 comments
Closed

Remove overflow menu for Open Editors panel #241025

thany opened this issue Feb 17, 2025 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@thany
Copy link

thany commented Feb 17, 2025

I would like to be able to remove this button:

Image

I think it's newly added, but I'm not totally sure.

Either way, I want the "close all" button (next to it) to be vertically aligned with the "collapse all" button from the workspaces panel.

I use these two buttons oftenly in quick succession to "clean" my workspace before starting on a new task, like this:

Image

Apart from my particular use-case, it doesn't make sense to me that one panel has an overflow menu, and another panel (with MORE actions), doesn't. But at the same time, I feel like definitely not everything needs an overflow menu, so we can also just remove them for all panels. After all, the options therein are not really earth shattering, are they. They are merely a repeat of the button that are already there.

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Feb 17, 2025

The overflow menu does not repeat buttons that are already there. Rather, it is a place that first-class actions can be demoted to, and a place where actions not considered first-class can be accessed.

For the alignment issue I propose that a "..." menu gets added to the title bar of the Explorer view. It could start off by having an option that gets to Settings editor with a set of relevant settings (the @feature:explorer filter, for example). Other items will surely follow once extensions are given the ability to contribute to this menu.

@gjsjohnmurray
Copy link
Contributor

See also #240073

@bpasero
Copy link
Member

bpasero commented Feb 17, 2025

Looks like this is from #237678

I know I approved that PR, but I see the downside of the additional "...". I am not sure the addition of the configuration discoverability justifies for this. In the end, we have countless of UI parts that are all configurable (including the explorer) where we do not show a specific action to jump to configuration, so in terms of UX we are very inconsistent.

//cc @benibenj

@benibenj benibenj self-assigned this Feb 17, 2025
@benibenj
Copy link
Contributor

/duplicate #240073

@vs-code-engineering vs-code-engineering bot added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 17, 2025
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
@thany
Copy link
Author

thany commented Feb 18, 2025

@bpasero

The overflow menu does not repeat buttons that are already there. Rather, it is a place that first-class actions can be demoted to, and a place where actions not considered first-class can be accessed.

Ok fair enough, but the action of removing a button for the sake of a clean UI, and not having buttons I don't need, does not merit adding an overflow menu. I want an action gone, not moved. The right click menu can be used to get an action back.

For the alignment issue I propose that a "..." menu gets added to the title bar of the Explorer view. It could start off by having an option that gets to Settings editor with a set of relevant settings (the @feature:explorer filter, for example). Other items will surely follow once extensions are given the ability to contribute to this menu.

Hard pass on that. I don't want a whole array of ... everywhere. That's just clutter.

@gjsjohnmurray
Copy link
Contributor

I'm hoping that my PR #241268 to resolve this will be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants