Theming: Some elements are not themable

[roblourens]

#23294

Not sure if these are in progress, but I changed every theme attribute to red/yellow so I can notice which elements aren't themable.

• Disable/uninstall buttons on extension page
  

• Welcome page
  
  

• Not all editor settings applied inside the welcome walkthrough
  

This one goes out to Hot Dog Stand

Items collected by @psuedosudo

• Disable and uninstall buttons

Extra

These might be out of scope for the initial workbench theming but as far as I can tell the buttons and badges used throughout the ui are also not themable.

• git file status badges and counts

• Install button

• reload button

[aeschli]

@bpasero I assume you set the March milestone as you are working on fixes?

[bpasero]

That is usually what it means.

[bpasero]

Awesome, just learned that there is a ::placeholder CSS pseudo element that can be used to theme the placeholder text 👍

Great findings, will continue in April.

[pseudo-su]

Some of these are duplicates but I'm cross-posting this here as requested in #3112

I've switched to insiders so I can test the Solarized Dark theme.

I'm not sure if these are issues with the theme or the theming support but I've tried to find all the ui areas that I think aren't themed yet. Some are pretty minor but hopefully it helps.

List copied to description...

[aeschli]

@psuedosudo Great list of missing items! Thanks! I copied them from your comment to the issue description, along with checkmarks to track our progress.

[davenport]

please consider adding:
editorColumnHighlight
editorColumnHighlightBorder
so that a cross-hair effect can be produced - old/tired eyes will appreciate it

[aeschli]

@davenport Can you add a screenshot? Not sure what you mean.

[davenport]

This is a screenshot from vim. Believe it or not this is usually a deal breaker for me when switching editors.

[Swiiip]

I'm not sure there is a way to customize minimap background as well (at least I did not find it).

[flying-circus]

I've got an impossible one: editor right click context menu.
It's not just an aesthetic thing, it always bothered me that if you are using a dark theme right clicks flash light into your eyes.

This might be so unfixable I am offtopic, but I think it's worth mentioning.

[benperiton]

I couldn't see it above, but would it be possible to add a background colour for the explorer title? That way the colour from the tabs and activity bar can flow through.

[bpasero]

There is!

[benperiton]

@bpasero I tried setting the INACTIVE and ACTIVE backgrounds, but they only affect the title bar, not the 'EXPLORER' heading - that was my bad for using the word 'title' instead of heading :)

[bpasero]

@benperiton there is only sideBarBackground right now.

[benperiton]

@bpasero Ah ok cool, something that could be added in the future?

[cleidigh]

More items identified:

Title/Editor action bar icons

Panel Drop-down\list focus color:

Debug Launch drop-down (select box) focus color:

Find Selected/Focused Text: (also file find):

[bpasero]

@cleidigh icons are not themable at all anywhere in the UI. The other ones are good catches, looks very bad especially on Windows where the selection color is so strong (compared to Windows).

[cleidigh]

@bpasero

• good to do something useful - I already learned select/options has platform and browser styling limitations
• I infer from your prior comments , best to have issues for each of these for tracking
• I also infer (other than the icons) that the other items having been there for a while so they have all been determined to be legitimate candidates , priority TBD

so I will do the following to set up for May milestones IF you agree:

• create individual issue for each theme item, common issue title "UI Theme Add: xyz" (easy search)
• copy image for reference, current UI color name where obvious or possible new names for discussion
• any known issues from above

Then you and the team can decide what goes into the May milestones, then discuss / assign

I am already working on the select box as mentioned interesting issues, may want to really be a single select list. Also found it odd not all UI items in color registry and default colors distributed in various places.

[equinusocio]

Tree default foreground color, there is only list.activeSelectionForeground but not the default status (active tree not selected list item/folder)

• Editor scroll shadows

[rfgamaral]

@equinusocio What icon theme are you using?

[equinusocio]

@rfgamaral Material Theme Icons from my Material Theme, https://github.com/equinusocio/vsc-material-theme

[be5invis]

Is the border of scroll bar themable?

[be5invis]

I do not see any option to change the color of the border of pair character indicator.

[bpasero]

I have extracted some issues for specific editor things that are not themable yet: #26102, #26103, #26104, #26105

[bpasero]

We continue working on this but will probably not get everything done for May, so moving to Backlog to focus on individual items as we see fit. Thanks for the input 👍

[pzuraq]

Is there a way to theme the intellisense parameter info popup?

[aeschli]

@pzuraq I created #26671

[aeschli]

Inspect TM Scopes dialog now also uses the hover colors

[bpasero]

Closing this one, I added support for extension buttons. The full list of new colors is available here: https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_13.md#theming

For things still missing I suggest to open separate issues (after checking for any existing duplicates).

[joeshub]

Would it be at all possible to somehow change the style of changed files in explorer? I know there is issue #178 but I thought it maybe a simple change so asking here. Thank you!

[Tyriar]

@joeshub outside of icon themes which you can use today, it's not a particularly simple change and #178 is the right spot for the discussion.

[joeshub]

@Tyriar that's exciting, looked it up, do you know by any chance if there's documentation on how to set up VS icons to reflect git status?

[Tyriar]

@joeshub I believe the icons can only be based on the type (folder/file) and the name of the file.