Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No "Restart TS Server" when viewing diff editor #201734

Open
rebornix opened this issue Jan 3, 2024 · 4 comments · Fixed by #201847
Open

No "Restart TS Server" when viewing diff editor #201734

rebornix opened this issue Jan 3, 2024 · 4 comments · Fixed by #201847
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues
Milestone
On Deck

Comments

@rebornix
Copy link
Member

rebornix commented Jan 3, 2024

  • Working on a branch with changes, open a diff editor for a modified ts file
  • Switch to another branch
  • TS Server generates a lot of unexpected errors
  • Now I want to restart the ts server to start fresh
  • Open Command Palette, the command is not available

image
mjbvz added a commit to mjbvz/vscode that referenced this issue Jan 4, 2024
@mjbvz
Show TS Server commands in diff editors and notebook cells
8561777 
Fixes microsoft#201734

Switches to use tabs so that we can enable TS commands if you're in a JS/TS editor in a diff editor or notebook cell
@mjbvz mjbvz mentioned this issue Jan 4, 2024
Merged
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Jan 4, 2024
@mjbvz mjbvz added this to the December / January 2024 milestone Jan 4, 2024
mjbvz added a commit that referenced this issue Jan 4, 2024
@mjbvz
Show TS Server commands in diff editors and notebook cells (#201847)
ee91ce8 
Fixes #201734

Switches to use tabs so that we can enable TS commands if you're in a JS/TS editor in a diff editor or notebook cell
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 4, 2024
@eleanorjboyd eleanorjboyd added the verification-steps-needed Steps to verify are needed for verification label Jan 25, 2024
@eleanorjboyd
Copy link
Member

So I should be creating a TS server or is this something with the editor?

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 25, 2024

To verify:

  • Open a diff of two ts files. You can select two files in the explorer and use compare selected
  • With either editor in the diff focused, make sure that TypeScript: Restart TS Server shows up in the command palette

@mjbvz mjbvz removed the verification-steps-needed Steps to verify are needed for verification label Jan 25, 2024
@eleanorjboyd eleanorjboyd added the verification-found Issue verification failed label Jan 25, 2024
@eleanorjboyd
Copy link
Member

I am unable to get the TypeScript: Restart TS Server to appear if I am in the left side of the diff view.

image

@mjbvz mjbvz reopened this Jan 25, 2024
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jan 25, 2024
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 25, 2024

Yes this is still disabled for git: files. Will take a look in February

@mjbvz mjbvz modified the milestones: December / January 2024, February 2024 Jan 25, 2024
@mjbvz mjbvz added insiders-released Patch has been released in VS Code Insiders and removed verification-found Issue verification failed labels Jan 25, 2024
@mjbvz mjbvz modified the milestones: February 2024, March 2024 Feb 23, 2024
@mjbvz mjbvz modified the milestones: March 2024, April 2024 Mar 25, 2024
@mjbvz mjbvz modified the milestones: April 2024, May 2024 Apr 22, 2024
@mjbvz mjbvz modified the milestones: May 2024, June 2024 May 24, 2024
@mjbvz mjbvz modified the milestones: June 2024, On Deck Jun 24, 2024
@dangerman dangerman mentioned this issue Jul 23, 2024
Closed
@mjbvz mjbvz mentioned this issue Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues
Projects
None yet
Milestone
On Deck
Development

Successfully merging a pull request may close this issue.

Show TS Server commands in diff editors and notebook cells mjbvz/vscode
4 participants
@rebornix @mjbvz @eleanorjboyd @vscodenpa