Model picker: use 'Models' in hover and aria-labels for consistency

Address PR review: the visible picker label is now 'Models', but the
hover tooltip and aria-labels still read 'Pick Model'. Name the control
'Models' in both (reusing the shared label key) so screen-reader and
hover copy match the visible UI. Reword the Restricted Mode suffixes to
avoid a 'Models • Models' / 'Models, models' stutter. Retire the now-unused
'Pick Model' string and refresh stale comments referencing it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: rwoll

src/vs/sessions/contrib/chat/browser/modelPicker.ts

@@ -160,8 +160,8 @@ export class ModelPicker extends Disposable {
 		// Re-evaluate when workspace trust changes (or finishes initializing): an
 		// untrusted workspace disables the model providers, and the shared widget
 		// then renders its Restricted Mode state. Visibility is recomputed so the
-		// picker stays visible to surface "Pick Model" + the Trust action instead
-		// of hiding as an empty picker.
+		// picker stays visible to surface the "Models" placeholder + the Trust
+		// action instead of hiding as an empty picker.
 		this._register(this._workspaceTrustManagementService.onDidChangeTrust(() => this._initModel()));
 		this._workspaceTrustManagementService.workspaceTrustInitialized.then(() => {
 			if (!this._store.isDisposed) {

src/vs/sessions/contrib/providers/agentHost/browser/agentHostSessionConfigPicker.ts

@@ -975,7 +975,7 @@ registerAction2(class extends Action2 {
 				group: 'navigation',
 				// `OpenModelPickerAction` (the "Auto" model picker) is at order 3
 				// in the same menu — sit just before it so the mode pill renders
-				// to the left of "Pick Model".
+				// to the left of the model picker.
 				order: 2,
 				// Hide the agent mode picker while a delegation (continue in) target is pending.
 				when: ContextKeyExpr.and(ChatContextKeyExprs.isAgentHostSession, ChatContextKeys.hasPendingDelegationTarget.negate()),

src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts

@@ -1555,12 +1555,13 @@ export class ModelPickerWidget extends Disposable {
 			}
 		}
 
-		// Aria
+		// Aria — name the control "Models" to match the visible label; the comma
+		// separates the control name from its current value / state.
 		this._domNode.ariaLabel = restrictedMode
-			? localize('chat.modelPicker.ariaLabelRestricted', "Pick Model, models unavailable while in Restricted mode")
+			? localize('chat.modelPicker.ariaLabelRestricted', "Models, unavailable while in Restricted mode")
 			: setupRequired
-				? localize('chat.modelPicker.ariaLabelSetupRequired', "Pick Model, sign in to use Copilot")
-				: localize('chat.modelPicker.ariaLabel', "Pick Model, {0}", fullLabel);
+				? localize('chat.modelPicker.ariaLabelSetupRequired', "Models, sign in to use Copilot")
+				: localize('chat.modelPicker.ariaLabel', "Models, {0}", fullLabel);
 	}
 
 	/**

src/vs/workbench/contrib/chat/browser/widget/input/chatModelSelectionLogic.ts

@@ -397,7 +397,7 @@ export function resolveConfiguredModel(
 
 /**
  * Why a model picker has no model to offer, when that is the case. Drives a
- * "Pick Model" placeholder plus a contextual action instead of a misleading
+ * "Models" placeholder plus a contextual action instead of a misleading
  * lone "Auto".
  */
 export const enum ModelPickerUnavailableReason {

src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts

@@ -163,13 +163,17 @@ export class ModelPickerActionItem extends BaseActionViewItem {
 	}
 
 	private _getHoverContents(): IManagedHoverContent {
-		let label = localize('chat.modelPicker.label', "Pick Model");
+		// Keep the hover prefix in sync with the picker's visible "Models" label
+		// (the same localization key) so the hover doesn't read "Pick Model • …".
+		let label = localize('chat.modelPicker.modelsLabel', "Models");
 		const keybindingLabel = this.keybindingService.lookupKeybinding(this._action.id, this._contextKeyService)?.getLabel();
 		if (keybindingLabel) {
 			label += ` (${keybindingLabel})`;
 		}
 		if (this._pickerWidget.isRestrictedMode()) {
-			return localize('chat.modelPicker.restrictedHover', "{0} • Models unavailable while in Restricted mode. Trust Workspace to enable models.", label);
+			// Suffix avoids a leading "Models" so the hover doesn't stutter as
+			// "Models • Models unavailable…" once the prefix is "Models".
+			return localize('chat.modelPicker.restrictedHover', "{0} • Unavailable while in Restricted mode. Trust Workspace to enable models.", label);
 		}
 		if (this._pickerWidget.isSetupRequired()) {
 			return localize('chat.modelPicker.setupRequiredHover', "{0} • Sign in to GitHub Copilot to choose a model.", label);