Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support packageJson.preRelease: true along packageJson.version #1112

Open
hediet opened this issue Jan 27, 2025 · 0 comments
Open

Support packageJson.preRelease: true along packageJson.version #1112

hediet opened this issue Jan 27, 2025 · 0 comments

Comments

@hediet
Copy link
Member

hediet commented Jan 27, 2025

Conceptually, the pre-release flag is tied to the version number.
However, at the moment, the version is specified in package.json, but the pre-release flag is passed in as cli argument, both for package and publish.
This also makes me wonder what happens when a vsix is packaged with --pre-release, but published without (and vice versa, packaged without and published with).
If the pre-release flag was read from package.json (from source or inside the given vsix file), it would be quite clear.

To fix issues like #947 and make it less confusing, I'd suggest that by default, the pre-release flag is read from a package.json property 'preRelease'.


It seems like publish only uses the --pre-release flag if the vsix still needs to be build (i.e. if no vsix is specified).

@hediet hediet changed the title Support packageJson.isPreRelease: true along packageJson.version Support packageJson.preRelease: true along packageJson.version Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant