Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoongArch64 support for Platform-specific extensions #1105

Open
realybin opened this issue Dec 17, 2024 · 0 comments
Open

Add LoongArch64 support for Platform-specific extensions #1105

realybin opened this issue Dec 17, 2024 · 0 comments

Comments

@realybin
Copy link

Currently, VSCode's platform-specific extensions support various targets but lacks support for the LoongArch64 architecture. This limits the distribution capabilities for extensions targeting this emerging platform.

vscode-vsce/src/package.ts

Lines 453 to 464 in 06951d9

export const Targets = new Set([
'win32-x64',
'win32-arm64',
'linux-x64',
'linux-arm64',
'linux-armhf',
'darwin-x64',
'darwin-arm64',
'alpine-x64',
'alpine-arm64',
'web',
]);

Current situation:

  • LoongArch64 is a new architecture gaining adoption (see benchmarks and support status on Phoronix: https://www.phoronix.com/search/LoongArch)
  • The current supported platforms are: win32-x64, win32-arm64, linux-x64, linux-arm64, linux-armhf, alpine-x64, alpine-arm64, darwin-x64, darwin-arm64 and web
  • Unable to access source code of npm @vscode/vsce-sign to implement support
    "node_modules/@vscode/vsce-sign": {
    "version": "2.0.3",
    "resolved": "https://registry.npmjs.org/@vscode/vsce-sign/-/vsce-sign-2.0.3.tgz",
    "integrity": "sha512-NYktTVXYIjJ41CTfImuWLYSw2UoZwYYFk7VcVYTjTZnD7NnuaM3DizaFZfuRG5YMRT/oZa1t1d4bwzrBALR3VQ==",
    "hasInstallScript": true,
    "optionalDependencies": {
    "@vscode/vsce-sign-alpine-arm64": "2.0.1",
    "@vscode/vsce-sign-alpine-x64": "2.0.1",
    "@vscode/vsce-sign-darwin-arm64": "2.0.1",
    "@vscode/vsce-sign-darwin-x64": "2.0.1",
    "@vscode/vsce-sign-linux-arm": "2.0.1",
    "@vscode/vsce-sign-linux-arm64": "2.0.1",
    "@vscode/vsce-sign-linux-x64": "2.0.1",
    "@vscode/vsce-sign-win32-arm64": "2.0.1",
    "@vscode/vsce-sign-win32-x64": "2.0.1"
    }
    },

Feature request:

  1. Add loongarch64 as a supported target platform for VSCode extensions
  2. Enable the --target flag to support loongarch64 platform specification
  3. Update relevant documentation to include the new target platform

While most extensions are platform-agnostic, having proper platform-specific packaging support would greatly improve distribution capabilities for the LoongArch64 ecosystem.

Would it be possible to add this support in a future release? Thanks

I can make pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant