Skip to content
This repository was archived by the owner on May 2, 2022. It is now read-only.

Commit 8cec022

Browse files
authored
Node function fix (#212)
* Staging URLs * Update remoteServiceUrlHelper.ts * Review comments * Review comments * All webapps to remote for github repos * function node fix * function node fix * fixed npm fail * Adding comment
1 parent 331f988 commit 8cec022

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
"tslint-microsoft-contrib": "^6.2.0",
136136
"typescript": "3.3.1",
137137
"typescript-tslint-plugin": "^0.5.5",
138-
"vscode": "1.1.33",
138+
"vscode": "1.1.37",
139139
"vscode-azureextensiondev": "^0.3.1",
140140
"vscode-test": "^1.3.0"
141141
},

src/configure/configure.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,10 @@ class Orchestrator {
116116
}
117117

118118
private doesLanguageAndTargetSupportRemoteProvisioning(): boolean {
119+
// This check is to enable for all remote repository webapps and aks flows to use remote provisioning service.
120+
// Both template type as remote and remote url check is required because remote provisioning is only applicable for remote templates and there are scenario where template selected is remote but repo is not remote (in cases where resource is already selected)
119121
return extensionVariables.remoteConfigurerEnabled === true && this.inputs.sourceRepository.repositoryProvider === RepositoryProvider.Github &&
120-
(this.inputs.targetResource.resource.type === TargetResourceType.AKS || this.inputs.targetResource.resource.type === TargetResourceType.WebApp) && !!this.inputs.sourceRepository.remoteUrl;
122+
(this.inputs.targetResource.resource.type === TargetResourceType.AKS || this.inputs.targetResource.resource.type === TargetResourceType.WebApp) && !!this.inputs.sourceRepository.remoteUrl && this.inputs.pipelineConfiguration.template.templateType === TemplateType.REMOTE;
121123
}
122124

123125
private async getAzureResource(targetType: TargetResourceType) {

0 commit comments

Comments
 (0)