Dialog window stuck no way to accept/close

[VDVsx]

Type: Bug

I believe I didn't activate copilot, the dialog appeared and became stuck, there was no visible way to accept or decline it. This behaviour also prevents me from saving the file.

Extension version: 0.20.3
VS Code version: Code 1.93.1 (Universal) (38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40, 2024-09-11T17:20:05.685Z)
OS version: Darwin x64 23.6.0
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz (8 x 2300)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off
Load (avg)	4, 4, 3
Memory (System)	32.00GB (0.09GB free)
Process Argv	--crash-reporter-id 6a90a1fd-f175-42ee-b2c5-2553b99f0d03
Screen Reader	no
VM	0%

A/B Experiments

vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
f8hc8238:30694864
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
jg8ic977:31013176
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
2f103344:31071589
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
flighttreat:31134774
wkspc-onlycs-t:31132770
wkspc-ranged-t:31125599
pme_test_c:31118331
fje88620:31121564
iacca2:31138163

Screenshot

[jrieken]

We have tweaked the flow here and the message should not appear anymore.

[jrieken]

To verify:

• use default for chat.editing.alwaysSaveWithGeneratedChanges
• disable/remove inlineChat.acceptedOrDiscardBeforeSave config (the upper one is the new truth)
• use inline chat to change a file
• notice that auto save is disabled for this file (if you use auto save the file is now dirty)
• save the file and notice a modal dialog informing you about saving with AI edits
• cancel will abort the save operation
• save will save but keep inline chat active
• save and the checkbox will update the setting from step 1