Use EasyNamedPipes for dotnet test protocol #6814
Draft
+99
−1,461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Nov 2, 2025
Youssef1313
reviewed
Nov 2, 2025
| <ItemGroup Label="Product dependencies"> | ||
| <!-- If this gets updated, please revise if the explicit dependency on System.Diagnostics.DiagnosticSource is still needed --> | ||
| <PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0" /> | ||
|
|
There was a problem hiding this comment.
nit: Revert unnecessary blank line change.
Youssef1313
reviewed
Nov 2, 2025
| <PackageVersion Include="Microsoft.Playwright.MSTest.v4" Version="$(MicrosoftPlaywrightVersion)" /> | ||
| </ItemGroup> | ||
| </Project> | ||
| </Project> |
There was a problem hiding this comment.
nit: add back blank line to the end of the file.
Youssef1313
reviewed
Nov 2, 2025
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record CommandLineOptionMessage(string? Name, string? Description, bool? IsHidden, bool? IsBuiltIn); | ||
| internal sealed record CommandLineOptionMessage( |
There was a problem hiding this comment.
Are we missing the attribute here?
Youssef1313
reviewed
Nov 2, 2025
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record DiscoveredTestMessage(string? Uid, string? DisplayName, string? FilePath, int? LineNumber, string? Namespace, string? TypeName, string? MethodName, string[]? ParameterTypeFullNames, TestMetadataProperty[] Traits); | ||
| internal sealed record DiscoveredTestMessage( |
There was a problem hiding this comment.
Are we missing the attribute here?
Youssef1313
reviewed
Nov 2, 2025
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record FileArtifactMessage(string? FullPath, string? DisplayName, string? Description, string? TestUid, string? TestDisplayName, string? SessionUid); | ||
| internal sealed record FileArtifactMessage( |
There was a problem hiding this comment.
Are we missing the attribute here?
Youssef1313
reviewed
Nov 2, 2025
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record SuccessfulTestResultMessage(string? Uid, string? DisplayName, byte? State, long? Duration, string? Reason, string? StandardOutput, string? ErrorOutput, string? SessionUid); | ||
| internal sealed record SuccessfulTestResultMessage( |
Youssef1313
reviewed
Nov 2, 2025
| [property: PipePropertyId(8)] string? SessionUid); | ||
|
|
||
| internal sealed record FailedTestResultMessage(string? Uid, string? DisplayName, byte? State, long? Duration, string? Reason, ExceptionMessage[]? Exceptions, string? StandardOutput, string? ErrorOutput, string? SessionUid); | ||
| internal sealed record FailedTestResultMessage( |
Youssef1313
reviewed
Nov 2, 2025
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Models/TestResultMessages.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Nov 2, 2025
| [property: PipePropertyId(4)] bool? IsBuiltIn); | ||
|
|
||
| internal sealed record CommandLineOptionMessages(string? ModulePath, CommandLineOptionMessage[]? CommandLineOptionMessageList) : IRequest; | ||
| [PipeSerializableMessage("DotNetTestProtocol", 3)] |
There was a problem hiding this comment.
Should we extract the message ID constants to a static class?
Co-authored-by: Youssef Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6351