Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git add . -p command input at incorrect position #18482

Closed
polyscone opened this issue Jan 31, 2025 · 2 comments
Closed

git add . -p command input at incorrect position #18482

polyscone opened this issue Jan 31, 2025 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@polyscone
Copy link

Windows Terminal version

1.22.241118002-preview

Windows build number

10.0.22631.4751

Other Software

clink in cmd
git

Steps to reproduce

Run git add . -p on a project with changes.

Expected Behavior

The screen should show a git diff with a prompt at the bottom.
When typing a prompt it should appear at the correct prompt position.
After pressing enter it should show the next diff with the prompt input in the correct position again.

Actual Behavior

The prompt input position is incorrect when typing.
When pressing enter the previous text is left on the screen and the prompt input is still in the incorrect position.

This is how it looks on the first prompt:

Image

This is how it looks when pressing enter; the previous output is mixed with the new output and the prompt is still in the incorrect position when typing:

Image

@polyscone polyscone added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 31, 2025
@polyscone
Copy link
Author

I tried canary version 1.23.10311.0 and it's not an issue there, so I'll close this for now.

@DHowett
Copy link
Member

DHowett commented Feb 3, 2025

Thanks for following up! I suspect that means #18326 fixed your issue.
It will be included in the 1.22 stable release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants