Skip to content

Commit 41acbf0

Browse files
committed
fix(windows): declare support for 0.84
1 parent 655624c commit 41acbf0

8 files changed

Lines changed: 11 additions & 9 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,6 @@ jobs:
545545
uses: ./.github/actions/setup-toolchain
546546
with:
547547
platform: windows
548-
node-version: 22
549548
- name: Set up react-native@canary
550549
if: ${{ github.event_name == 'schedule' }}
551550
uses: ./.github/actions/setup-react-native
@@ -561,7 +560,7 @@ jobs:
561560
working-directory: packages/example-windows
562561
- name: Generate Visual Studio solution
563562
run: |
564-
node ../app/windows/app.mjs --msbuildprops WindowsTargetPlatformVersion=$env:WindowsTargetPlatformVersion
563+
node --run prebuild -- --msbuildprops WindowsTargetPlatformVersion=$env:WindowsTargetPlatformVersion
565564
working-directory: packages/example-windows
566565
- name: Test `react-native config`
567566
run: |
@@ -614,11 +613,10 @@ jobs:
614613
uses: ./.github/actions/setup-toolchain
615614
with:
616615
platform: windows
617-
node-version: 22
618616
- name: Initialize test app
619617
uses: ./.github/actions/init-test-app
620618
with:
621-
arguments: -p windows --version 0.83.0
619+
arguments: -p windows
622620
- name: Bundle JavaScript
623621
run: |
624622
yarn build:windows

.yarnrc.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ catalog:
22
"@babel/core": ^7.25.2
33
"@babel/preset-env": ^7.25.3
44
"@react-native-webapis/web-storage": ^0.4.5
5+
"@types/node": ^24.0.0
56
"@rnx-kit/cli": ^2.0.1
67
"@rnx-kit/metro-config": ^2.2.4
78
"@rnx-kit/polyfills": ^0.3.0

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@swc-node/register": "^1.11.1",
3939
"@swc/core": "^1.15.8",
4040
"@types/js-yaml": "^4.0.5",
41-
"@types/node": "^24.0.0",
41+
"@types/node": "catalog:",
4242
"eslint-plugin-wdio": "^9.26.0",
4343
"globals": "^16.5.0",
4444
"js-yaml": "^4.1.0",

packages/app/example/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"@rnx-kit/polyfills": "catalog:",
3838
"@rnx-kit/react-native-template-web": "workspace:*",
3939
"@rnx-kit/tsconfig": "catalog:",
40+
"@types/node": "catalog:",
4041
"@types/react": "~19.2.0",
4142
"@wdio/types": "^9.20.0",
4243
"appium": "^3.1.1",

packages/app/example/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "@rnx-kit/tsconfig/tsconfig.json",
2+
"extends": "@rnx-kit/tsconfig/tsconfig.nodenext.json",
33
"compilerOptions": {
44
"jsx": "react-native",
55
"noEmit": true,

packages/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
"react": "18.2 - 19.2",
127127
"react-native": "0.76 - 0.86 || >=0.86.0-0 <0.87.0",
128128
"react-native-macos": "^0.0.0-0 || 0.76 - 0.81",
129-
"react-native-windows": "^0.0.0-0 || 0.76 - 0.83"
129+
"react-native-windows": "^0.0.0-0 || 0.76 - 0.84"
130130
},
131131
"peerDependenciesMeta": {
132132
"@callstack/react-native-visionos": {

packages/example-windows/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"ci:windows": "rnx-cli run-windows --logging --no-packager --no-launch --no-deploy --msbuildprops UseBundle=false --no-telemetry",
1111
"clean": "yarn workspace react-native-test-app clean",
1212
"ios": "rnx-cli run --platform ios",
13+
"prebuild": "node ../app/windows/app.mjs",
1314
"set-react-version": "yarn workspace react-native-test-app set-react-version",
1415
"start": "rnx-cli start",
1516
"windows": "rnx-cli run-windows --no-packager"

yarn.lock

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2495,7 +2495,7 @@ __metadata:
24952495
"@swc-node/register": "npm:^1.11.1"
24962496
"@swc/core": "npm:^1.15.8"
24972497
"@types/js-yaml": "npm:^4.0.5"
2498-
"@types/node": "npm:^24.0.0"
2498+
"@types/node": "catalog:"
24992499
eslint-plugin-wdio: "npm:^9.26.0"
25002500
globals: "npm:^16.5.0"
25012501
js-yaml: "npm:^4.1.0"
@@ -8390,6 +8390,7 @@ __metadata:
83908390
"@rnx-kit/polyfills": "catalog:"
83918391
"@rnx-kit/react-native-template-web": "workspace:*"
83928392
"@rnx-kit/tsconfig": "catalog:"
8393+
"@types/node": "catalog:"
83938394
"@types/react": "npm:~19.2.0"
83948395
"@wdio/types": "npm:^9.20.0"
83958396
appium: "npm:^3.1.1"
@@ -13061,7 +13062,7 @@ __metadata:
1306113062
react: 18.2 - 19.2
1306213063
react-native: 0.76 - 0.86 || >=0.86.0-0 <0.87.0
1306313064
react-native-macos: ^0.0.0-0 || 0.76 - 0.81
13064-
react-native-windows: ^0.0.0-0 || 0.76 - 0.83
13065+
react-native-windows: ^0.0.0-0 || 0.76 - 0.84
1306513066
peerDependenciesMeta:
1306613067
"@callstack/react-native-visionos":
1306713068
optional: true

0 commit comments

Comments
 (0)