Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of Final in typed dictionaries and named tuples #9767

Closed
Viicos opened this issue Jan 27, 2025 · 1 comment
Closed

Usage of Final in typed dictionaries and named tuples #9767

Viicos opened this issue Jan 27, 2025 · 1 comment
Labels
addressed in next version Issue is fixed and will appear in next published version bug Something isn't working

Comments

@Viicos
Copy link

Viicos commented Jan 27, 2025

#9526 adds a check when ClassVar is used as a type qualifier for typed dictionaries and named tuples, as per python/typing#1890.

However, it seems that Final wasn't included in the check.
@Viicos Viicos added the bug Something isn't working label Jan 27, 2025
erictraut added a commit that referenced this issue Jan 28, 2025
@erictraut
Added missing check for illegal use of Final within a TypedDict or …
5f1c198 
…NamedTuple definition. This addresses #9767.
@erictraut erictraut mentioned this issue Jan 28, 2025
Merged
erictraut added a commit that referenced this issue Jan 28, 2025
@erictraut
Added missing check for illegal use of Final within a TypedDict or …
e6d30a9 
…NamedTuple definition. This addresses #9767. (#9773)
@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label Jan 28, 2025
@erictraut
Copy link
Collaborator

This is addressed in pyright 1.1.393.

@erictraut erictraut reopened this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed in next version Issue is fixed and will appear in next published version bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erictraut @Viicos