Skip to content

Commit d4bf8d2

Browse files
authored
devops: migrate to OIDC for Docker publishing (#2412)
1 parent 2e4e81b commit d4bf8d2

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

.github/workflows/publish_docker.yml

+12-5
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,24 @@ jobs:
1616
name: "publish to DockerHub"
1717
runs-on: ubuntu-22.04
1818
if: github.repository == 'microsoft/playwright-python'
19+
permissions:
20+
id-token: write # This is required for OIDC login (azure/login) to succeed
21+
contents: read # This is required for actions/checkout to succeed
22+
environment: Docker
1923
steps:
2024
- uses: actions/checkout@v3
25+
- name: Azure login
26+
uses: azure/login@v2
27+
with:
28+
client-id: ${{ secrets.AZURE_DOCKER_CLIENT_ID }}
29+
tenant-id: ${{ secrets.AZURE_DOCKER_TENANT_ID }}
30+
subscription-id: ${{ secrets.AZURE_DOCKER_SUBSCRIPTION_ID }}
31+
- name: Login to ACR via OIDC
32+
run: az acr login --name playwright
2133
- name: Set up Python
2234
uses: actions/setup-python@v4
2335
with:
2436
python-version: "3.10"
25-
- uses: azure/docker-login@v1
26-
with:
27-
login-server: playwright.azurecr.io
28-
username: playwright
29-
password: ${{ secrets.DOCKER_PASSWORD }}
3037
- name: Set up Docker QEMU for arm64 docker builds
3138
uses: docker/setup-qemu-action@v2
3239
with:

0 commit comments

Comments
 (0)