Review feedback

Author: mxschmitt

driver-bundle/src/main/java/com/microsoft/playwright/impl/driver/jar/DriverJar.java

@@ -40,6 +40,7 @@ public DriverJar() throws IOException {
     driverTempDir = alternativeTmpdir == null
       ? Files.createTempDirectory(prefix)
       : Files.createTempDirectory(Paths.get(alternativeTmpdir), prefix);
+    driverTempDir.toFile().deleteOnExit();
     String nodePath = System.getProperty("playwright.nodejs.path");
     if (nodePath != null) {
       preinstalledNodePath = Paths.get(nodePath);
@@ -86,11 +87,10 @@ private void installBrowsers(Map<String, String> env) throws IOException, Interr
     }
     ProcessBuilder pb = createProcessBuilder();
     pb.command().add("install");
-    logMessage("Executing: " + String.join(" ", pb.command()));
     pb.redirectError(ProcessBuilder.Redirect.INHERIT);
     pb.redirectOutput(ProcessBuilder.Redirect.INHERIT);
     Process p = pb.start();
-    boolean result = p.waitFor(30, TimeUnit.MINUTES);
+    boolean result = p.waitFor(10, TimeUnit.MINUTES);
     if (!result) {
       p.destroy();
       throw new RuntimeException("Timed out waiting for browsers to install");

playwright/src/test/java/com/microsoft/playwright/TraceViewerPage.java

@@ -23,58 +23,58 @@
 import com.microsoft.playwright.impl.driver.Driver;
 import com.microsoft.playwright.options.AriaRole;
 
-public class TraceViewerPage {
+class TraceViewerPage {
   private final Page page;
 
-  public TraceViewerPage(Page page) {
+  TraceViewerPage(Page page) {
     this.page = page;
   }
 
-  public Page page() {
+  Page page() {
     return page;
   }
 
-  public Locator actionsTree() {
+  Locator actionsTree() {
     return page.getByTestId("actions-tree");
   }
 
-  public Locator actionTitles() {
+  Locator actionTitles() {
     return page.locator(".action-title");
   }
 
-  public Locator stackFrames() {
+  Locator stackFrames() {
     return this.page.getByRole(AriaRole.LIST, new Page.GetByRoleOptions().setName("stack trace")).getByRole(AriaRole.LISTITEM);
   }
 
-  public void selectAction(String title, int ordinal) {
+  void selectAction(String title, int ordinal) {
     this.actionsTree().getByTitle(title).nth(ordinal).click();
   }
 
-  public void selectAction(String title) {
+  void selectAction(String title) {
     selectAction(title, 0);
   }
 
-  public void selectSnapshot(String name) {
+  void selectSnapshot(String name) {
     this.page.getByRole(AriaRole.TAB, new Page.GetByRoleOptions().setName(name)).click();
   }
 
-  public FrameLocator snapshotFrame(String actionName, int ordinal, boolean hasSubframe) {
+  FrameLocator snapshotFrame(String actionName, int ordinal, boolean hasSubframe) {
     selectAction(actionName, ordinal);
     while (page.frames().size() < (hasSubframe ? 4 : 3)) {
       page.waitForTimeout(200);
     }
     return page.frameLocator("iframe.snapshot-visible[name=snapshot]");
   }
 
-  public FrameLocator snapshotFrame(String actionName, int ordinal) {
+  FrameLocator snapshotFrame(String actionName, int ordinal) {
     return snapshotFrame(actionName, ordinal, false);
   }
 
-  public void showSourceTab() {
+  void showSourceTab() {
     page.getByRole(AriaRole.TAB, new Page.GetByRoleOptions().setName("Source")).click();
   }
 
-  public void expandAction(String title) {
+  void expandAction(String title) {
     this.actionsTree().getByRole(AriaRole.TREEITEM, new Locator.GetByRoleOptions().setName(title)).locator(".codicon-chevron-right").click();
   }