Fix FTP proxy environment spec on main - #923
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the proxy environment contract test to match FTP proxy behavior and resolve #922.
Changes:
- Expects
FTP_PROXYandftp_proxyto use the configured proxy URL. - Corrects the associated test comment.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Branden Bonaby (bbonaby)
approved these changes
Aug 15, 2026
5 tasks
Darren Hoehna (dhoehna)
added a commit
to dhoehna/mxc
that referenced
this pull request
Aug 15, 2026
`cooperative_env_scrubs_all_caller_supplied_proxy_keys` asserted FTP_PROXY was absent while a sibling test asserted every PROXY_SET_KEYS entry was present at the proxy URL. microsoft#923 corrected the assertion; nothing yet stops the next hand-written per-key expectation from drifting the same way. `every_managed_key_lands_in_the_state_its_constants_dictate` derives the expected state of all ten managed keys from PROXY_SET_KEYS and PROXY_NEUTRALIZE_KEYS rather than naming keys by hand, under hostile caller input for every key. No existing test covered that combination: the scrub test supplies hostile values but checks three keys, and the set test checks every key but starts from an empty caller environment. Extends the WSLc proxy e2e to the FTP family for the same reason. The assertion is case-sensitive because PowerShell `-notmatch` is not, which would let the upper-case entry satisfy both checks and leave a lower-case attacker value untested. Refs microsoft#922 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: acf3853b-fbe3-41ab-870a-9274a698cc0c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Updates the proxy environment contract test to expect FTP_PROXY and ftp_proxy to be replaced with the configured proxy URL, matching current behavior.
🔗 References
Fixes #922.
🔍 Validation
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.
Microsoft Reviewers: Open in CodeFlow