Expose ProcessContainer config in Rust SDK - #881
Closed
Branden Bonaby (bbonaby) wants to merge 4 commits into
Closed
Expose ProcessContainer config in Rust SDK#881Branden Bonaby (bbonaby) wants to merge 4 commits into
Branden Bonaby (bbonaby) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8d4b87-97bc-49cb-b319-552e89e3e21e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8d4b87-97bc-49cb-b319-552e89e3e21e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8d4b87-97bc-49cb-b319-552e89e3e21e
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes explicit Windows ProcessContainer configuration through the Rust SDK.
Changes:
- Adds
ProcessContainersettings for capabilities and least privilege. - Maps settings through shared wire validation.
- Re-exports the new public SDK type and adds tests.
Show a summary per file
| File | Description |
|---|---|
src/core/mxc-sdk/src/lib.rs |
Exposes and references ProcessContainer. |
src/core/mxc_engine/src/policy.rs |
Implements configuration mapping and tests. |
src/core/mxc_engine/src/lib.rs |
Re-exports the configuration type. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
| platform_support, temporary_files_policy, user_profile_policy, AvailableBackend, | ||
| BackendCapability, Containment, Error, ErrorCode, FilesystemPolicyResult, PlatformSupport, | ||
| SandboxPolicy, SandboxRequest, WslcSection, | ||
| ProcessContainer, SandboxPolicy, SandboxRequest, WslcSection, |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8d4b87-97bc-49cb-b319-552e89e3e21e
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
src/core/mxc_engine/src/process_container_config.rs:15
- The public config still cannot represent all ProcessContainer-specific settings:
uiis part of both stable contracts (for exampleschemas/stable/mxc-config.schema.0.7.0-alpha.json:231), but it is omitted here and the factory always substitutesProcessContainerUi::default(); the 0.8learningModesetting is also absent. Rust SDK callers therefore cannot configure those supported backend fields, leaving the linked ProcessContainer-config task only partially implemented. Add version-aware public UI/learning-mode fields and serialize the caller's values while retaining the current defaults.
pub struct ProcessContainer {
/// Enforce least-privilege mode.
pub least_privilege: bool,
/// Additional AppContainer capabilities, such as `registryRead`.
pub capabilities: Vec<String>,
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Balanced
| let _ = (policy, container_id); | ||
| } | ||
|
|
||
| Ok(()) |
Collaborator
Author
|
Closing in favor of a more modular v3 implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Superseded by a more modular v3 design.
🔗 References
Parent: #887.
🔍 Validation
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type