Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated icons used through-out the code! #8375

Closed
Jay-o-Way opened this issue Apr 8, 2023 · 5 comments · Fixed by #8379
Closed

Deprecated icons used through-out the code! #8375

Jay-o-Way opened this issue Apr 8, 2023 · 5 comments · Fixed by #8379
Labels
bug Something isn't working team-Controls Issue for the Controls team working on it

Comments

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Apr 8, 2023 •
edited
Loading

Describe the bug

As Microsoft has declared icon codes ranging E0** - E5** as deprecated (1) who-knows-how-long-ago, Microsoft should follow their own rules. Yet, up till now, there are loads of icon codes used in the repo. This is mostly notable in CJK context, where these icons show as "garbled chinese" characters. I've seen cases of people showing this bad UI even in the search bar in Windows Explorer. One of the most "core" things of Windows!

  1. Message

Steps to reproduce the bug

it's the code

Screenshots

image

Additional context

old icon appearance new icon
E001 ✔ E73E
10A ✖
8BB close
947 multiply
→ 894 clear
711 cancel
052 👁 F78D
26B chev.R.small 970
26C chev.L.small 96F
0E2 chev.L 76B
0E3 chev.R 76C
0E4 chev.U 70E
0E5 chev.D 70D
094,11A 🔎 721
00B 🖤 B52
115 ⚙ 713
@Jay-o-Way Jay-o-Way added the bug Something isn't working label Apr 8, 2023
This was referenced Apr 8, 2023
Closed
Open
@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Apr 9, 2023 •
edited
Loading

Random examples:

@Jay-o-Way Jay-o-Way mentioned this issue Apr 10, 2023
Closed
2 tasks
@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Apr 10, 2023 •
edited
Loading

FYI @MarissaMatt @licanhua @codendone @StephenLPeters @ArvinZJC @zhuxb711 @hickeys @bpulliam @ranjeshj
This should be top priority imo

This was referenced Apr 10, 2023
Closed
Closed
Merged
This was referenced Apr 10, 2023
Closed
Closed
@licanhua
Copy link
Contributor

@kmahone Do you know about this?

@Jay-o-Way Jay-o-Way mentioned this issue Apr 30, 2023
Closed
@kmahone
Copy link
Member

kmahone commented May 23, 2023

Hi @Jay-o-Way, thanks for reporting.
@karkarl is investigating this.

@Jay-o-Way Jay-o-Way mentioned this issue Jun 22, 2023
Closed
@bpulliam bpulliam added the team-Controls Issue for the Controls team label Aug 22, 2023
@JJBrychell
Copy link

This was fixed in 1.4. Old codepoints are currently being translated to the new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working team-Controls Issue for the Controls team working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Deprecated icons
5 participants
@JJBrychell @licanhua @bpulliam @kmahone @Jay-o-Way