feat: construct training loop orchestrator (#171)

* feat: contsruct trainling loop orchestrator

* add tests

* resolve comments

---------

Co-authored-by: Kavya Sree Kaitepalli <kkaitepalli@microsoft.com>

Author: KavyaSree2610

src/microbots/auto_memory/callbacks.py

@@ -145,6 +145,11 @@ def _run_one(
                 stdout_path.open("w", encoding="utf-8") as out_fh,
                 stderr_path.open("w", encoding="utf-8") as err_fh,
             ):
+                # Security note: spec.command is intentionally run with
+                # shell=True for developer convenience (supports pipes,
+                # redirects, etc.).  This runner assumes configs are loaded
+                # from trusted local files only.  Do NOT use with configs
+                # sourced from untrusted input.
                 proc = subprocess.run(
                     spec.command,
                     shell=True,

src/microbots/auto_memory/config.py

@@ -140,6 +140,11 @@ def validate(self) -> None:
                 f"'output_path' must be a relative path, got '{self.output_path}'"
             )
 
+        if ".." in Path(self.output_path).parts:
+            raise ConfigError(
+                f"'output_path' must not contain '..', got '{self.output_path}'"
+            )
+
         if not self.callbacks:
             raise ConfigError("'callbacks' must contain at least one entry")
 

src/microbots/auto_memory/context.py

@@ -7,6 +7,8 @@
 from microbots.auto_memory.config import TaskConfig
 from microbots.auto_memory.data_models import Feedback
 
+_JINJA_ENV = JinjaEnvironment(undefined=StrictUndefined, keep_trailing_newline=True)
+
 
 def build_iteration_context(
     config: TaskConfig,
@@ -40,7 +42,7 @@ def build_iteration_context(
     str
         The rendered prompt text, ready to be sent to the agent.
     """
-    env = JinjaEnvironment(undefined=StrictUndefined, keep_trailing_newline=True)
+    env = _JINJA_ENV
     template = env.from_string(config.prompt_template)
     return template.render(
         task=config.task_definition,

src/microbots/auto_memory/errors.py

@@ -17,7 +17,7 @@ class CallbackError(AutoMemoryError):
     """Raised when a callback cannot be spawned or set up (not a failing assertion)."""
 
 
-class TimeoutError(AutoMemoryError):  # noqa: A001 — intentional shadow of builtin
+class AutoMemoryTimeoutError(AutoMemoryError):
     """Raised when the per-iteration or total run timeout is exceeded."""
 
 

src/microbots/auto_memory/memory.py

@@ -105,16 +105,20 @@ def read_all(self) -> list[Feedback]:
         """Return all persisted :class:`~microbots.auto_memory.data_models.Feedback` entries.
 
         Returns an empty list if the feedback file does not exist yet.
+        Lines that contain invalid JSON, non-object JSON, or fields that cannot
+        be mapped to :class:`~microbots.auto_memory.data_models.Feedback` are
+        skipped with a ``WARNING`` log message rather than raising an exception.
 
         Returns
         -------
         list[Feedback]
-            All feedback entries in the order they were appended.
+            Successfully parsed entries in the order they were appended.
+            Corrupt or malformed lines are omitted.
 
         Raises
         ------
         MemoryStoreError
-            If not mounted or on I/O / parse error.
+            If not mounted, or if the file cannot be opened (I/O error).
         """
         self._require_mounted()
         if not self._feedback_path.exists():  # type: ignore[union-attr]
@@ -130,23 +134,32 @@ def read_all(self) -> list[Feedback]:
                     try:
                         data = json.loads(line)
                     except json.JSONDecodeError as exc:
-                        raise MemoryStoreError(
-                            f"Invalid JSON on line {lineno} of "
-                            f"{self._feedback_path}: {exc}"
-                        ) from exc
+                        logger.warning(
+                            "Skipping corrupt JSON on line %d of %s: %s",
+                            lineno,
+                            self._feedback_path,
+                            exc,
+                        )
+                        continue
                     if not isinstance(data, dict):
-                        raise MemoryStoreError(
-                            f"Expected a JSON object on line {lineno} of "
-                            f"{self._feedback_path}, got {type(data).__name__}"
+                        logger.warning(
+                            "Skipping non-object entry on line %d of %s (got %s)",
+                            lineno,
+                            self._feedback_path,
+                            type(data).__name__,
                         )
+                        continue
                     known = {f.name for f in dataclasses.fields(Feedback)}
                     try:
                         entries.append(Feedback(**{k: v for k, v in data.items() if k in known}))
                     except TypeError as exc:
-                        raise MemoryStoreError(
-                            f"Cannot construct Feedback from line {lineno} of "
-                            f"{self._feedback_path}: {exc}"
-                        ) from exc
+                        logger.warning(
+                            "Skipping malformed Feedback on line %d of %s: %s",
+                            lineno,
+                            self._feedback_path,
+                            exc,
+                        )
+                        continue
         except OSError as exc:
             raise MemoryStoreError(f"Failed to read feedback: {exc}") from exc
 
@@ -190,3 +203,23 @@ def _require_mounted(self) -> None:
             raise MemoryStoreError(
                 "MemoryStore has not been mounted; call mount() first"
             )
+
+    @property
+    def memory_dir(self) -> Path:
+        """Absolute path to the memory directory.
+
+        Returns
+        -------
+        Path
+            The directory that holds the feedback file.
+
+        Raises
+        ------
+        MemoryStoreError
+            If the store has not been mounted yet.
+        """
+        if self._memory_dir is None:
+            raise MemoryStoreError(
+                "MemoryStore has not been mounted; call mount() first"
+            )
+        return self._memory_dir