From bc3a1442868d51b2e0aef226bf2865a3fdf5f834 Mon Sep 17 00:00:00 2001 From: sage-mode-hunter Date: Wed, 1 Jul 2026 13:22:27 +0530 Subject: [PATCH 1/2] Fix cleanup in FreeDialogResult --- UI/addinui.cpp | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/UI/addinui.cpp b/UI/addinui.cpp index 1177205f0..dcd57c113 100644 --- a/UI/addinui.cpp +++ b/UI/addinui.cpp @@ -162,18 +162,20 @@ namespace ui::addinui __declspec(dllexport) void __cdecl FreeDialogResult(_In_ LPADDINDIALOGRESULT lpDialogResult) { if (lpDialogResult) - { - if (lpDialogResult->lpDialogControlResults) { - for (ULONG i = 0; i < lpDialogResult->ulNumControls; i++) + if (lpDialogResult->lpDialogControlResults) { - delete[] lpDialogResult->lpDialogControlResults[i].lpBin; - delete[] lpDialogResult->lpDialogControlResults[i].szText; + for (ULONG i = 0; i < lpDialogResult->ulNumControls; i++) + { + delete[] lpDialogResult->lpDialogControlResults[i].lpBin; + delete[] lpDialogResult->lpDialogControlResults[i].szText; + } + + delete[] lpDialogResult->lpDialogControlResults; } - } - delete[] lpDialogResult; - } + delete lpDialogResult; + } } // Adds menu items appropriate to the context From 605b05e7a35bed5854200106631c5c152973b331 Mon Sep 17 00:00:00 2001 From: sage-mode-hunter Date: Thu, 2 Jul 2026 13:57:38 +0530 Subject: [PATCH 2/2] Fix indentation in FreeDialogResult --- UI/addinui.cpp | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/UI/addinui.cpp b/UI/addinui.cpp index dcd57c113..0d7304cc0 100644 --- a/UI/addinui.cpp +++ b/UI/addinui.cpp @@ -162,20 +162,19 @@ namespace ui::addinui __declspec(dllexport) void __cdecl FreeDialogResult(_In_ LPADDINDIALOGRESULT lpDialogResult) { if (lpDialogResult) + { + if (lpDialogResult->lpDialogControlResults) { - if (lpDialogResult->lpDialogControlResults) + for (ULONG i = 0; i < lpDialogResult->ulNumControls; i++) { - for (ULONG i = 0; i < lpDialogResult->ulNumControls; i++) - { - delete[] lpDialogResult->lpDialogControlResults[i].lpBin; - delete[] lpDialogResult->lpDialogControlResults[i].szText; - } - - delete[] lpDialogResult->lpDialogControlResults; + delete[] lpDialogResult->lpDialogControlResults[i].lpBin; + delete[] lpDialogResult->lpDialogControlResults[i].szText; } - - delete lpDialogResult; } + + delete[] lpDialogResult->lpDialogControlResults; + delete lpDialogResult; + } } // Adds menu items appropriate to the context