Skip to content

Commit 029ef2e

Browse files
authored
Merge pull request #2724 from microsoft/dev/qmuntal/windows-archive-signatures
eng: include Windows archive signature links
2 parents 88e8934 + 6af5721 commit 029ef2e

4 files changed

Lines changed: 61 additions & 10 deletions

File tree

‎eng/_util/cmd/updatelinktable/updatelinktable.go‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,11 @@ var linuxLikeFiles = []goFileType{
7878

7979
var windowsFiles = []goFileType{
8080
{
81-
Kind: supportdata.Archive,
82-
Name: "Binaries (zip)",
83-
Ext: ".zip",
84-
Checksum: true,
81+
Kind: supportdata.Archive,
82+
Name: "Binaries (zip)",
83+
Ext: ".zip",
84+
Checksum: true,
85+
Signature: true,
8586
},
8687
}
8788

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Use of this source code is governed by a BSD-style
3+
// license that can be found in the LICENSE file.
4+
5+
package main
6+
7+
import (
8+
"strings"
9+
"testing"
10+
11+
"github.com/microsoft/go/_util/supportdata"
12+
)
13+
14+
func TestWindowsArchiveSignatures(t *testing.T) {
15+
table, branches := data()
16+
for i, version := range supported {
17+
for platform := range version.Platforms {
18+
if !strings.HasPrefix(platform, "windows-") {
19+
continue
20+
}
21+
t.Run(version.Number+"/"+platform, func(t *testing.T) {
22+
name := "go" + version.Number + "." + platform + ".zip"
23+
url := baseURL + name
24+
var artifact *supportdata.LatestLink
25+
for _, file := range branches[i].Files {
26+
if file.Filename == name && file.Kind == supportdata.Archive {
27+
artifact = file
28+
break
29+
}
30+
}
31+
if artifact == nil {
32+
t.Fatalf("Windows archive %q missing from branch metadata", name)
33+
}
34+
if artifact.URL != url || artifact.ChecksumURL != url+".sha256" {
35+
t.Errorf("archive or checksum URL changed: URL = %q, ChecksumURL = %q", artifact.URL, artifact.ChecksumURL)
36+
}
37+
if want := url + ".sig"; artifact.SignatureURL != want {
38+
t.Errorf("SignatureURL = %q, want %q", artifact.SignatureURL, want)
39+
}
40+
if link := "[" + signatureMsg + "](" + url + ".sig)"; !strings.Contains(table, link) {
41+
t.Errorf("download table missing signature link %q", link)
42+
}
43+
})
44+
}
45+
}
46+
}

‎eng/doc/Downloads.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ For example, a 1.20 link will download 1.20.8-1 if that is the latest version of
2222
linux-amd64 | - [Binaries (tar.gz)](https://aka.ms/golang/release/latest/go1.27.linux-amd64.tar.gz)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.27.linux-amd64.tar.gz.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.27.linux-amd64.tar.gz.sig)<br/> | - [Binaries (tar.gz)](https://aka.ms/golang/release/latest/go1.26.linux-amd64.tar.gz)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.26.linux-amd64.tar.gz.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.26.linux-amd64.tar.gz.sig)<br/> |
2323
linux-arm64 | - [Binaries (tar.gz)](https://aka.ms/golang/release/latest/go1.27.linux-arm64.tar.gz)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.27.linux-arm64.tar.gz.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.27.linux-arm64.tar.gz.sig)<br/> | - [Binaries (tar.gz)](https://aka.ms/golang/release/latest/go1.26.linux-arm64.tar.gz)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.26.linux-arm64.tar.gz.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.26.linux-arm64.tar.gz.sig)<br/> |
2424
linux-armv6l | - [Binaries (tar.gz)](https://aka.ms/golang/release/latest/go1.27.linux-armv6l.tar.gz)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.27.linux-armv6l.tar.gz.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.27.linux-armv6l.tar.gz.sig)<br/> | - [Binaries (tar.gz)](https://aka.ms/golang/release/latest/go1.26.linux-armv6l.tar.gz)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.26.linux-armv6l.tar.gz.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.26.linux-armv6l.tar.gz.sig)<br/> |
25-
windows-amd64 | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip.sha256)<br/> | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip.sha256)<br/> |
26-
windows-arm64 | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip.sha256)<br/> | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip.sha256)<br/> |
25+
windows-amd64 | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip.sig)<br/> | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip.sig)<br/> |
26+
windows-arm64 | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip.sig)<br/> | - [Binaries (zip)](https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip)<br/>- [Checksum (SHA256)](https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip.sha256)<br/>- [Signature<sup>1</sup>](https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip.sig)<br/> |
2727

2828

2929
<!-- END TABLES -->

‎eng/doc/release-branch-links.json‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@
7979
"version": "go1.27",
8080
"kind": "archive",
8181
"url": "https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip",
82-
"checksumURL": "https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip.sha256"
82+
"checksumURL": "https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip.sha256",
83+
"signatureURL": "https://aka.ms/golang/release/latest/go1.27.windows-amd64.zip.sig"
8384
},
8485
{
8586
"filename": "go1.27.windows-arm64.zip",
@@ -88,7 +89,8 @@
8889
"version": "go1.27",
8990
"kind": "archive",
9091
"url": "https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip",
91-
"checksumURL": "https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip.sha256"
92+
"checksumURL": "https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip.sha256",
93+
"signatureURL": "https://aka.ms/golang/release/latest/go1.27.windows-arm64.zip.sig"
9294
}
9395
]
9496
},
@@ -172,7 +174,8 @@
172174
"version": "go1.26",
173175
"kind": "archive",
174176
"url": "https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip",
175-
"checksumURL": "https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip.sha256"
177+
"checksumURL": "https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip.sha256",
178+
"signatureURL": "https://aka.ms/golang/release/latest/go1.26.windows-amd64.zip.sig"
176179
},
177180
{
178181
"filename": "go1.26.windows-arm64.zip",
@@ -181,7 +184,8 @@
181184
"version": "go1.26",
182185
"kind": "archive",
183186
"url": "https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip",
184-
"checksumURL": "https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip.sha256"
187+
"checksumURL": "https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip.sha256",
188+
"signatureURL": "https://aka.ms/golang/release/latest/go1.26.windows-arm64.zip.sig"
185189
}
186190
]
187191
}

0 commit comments

Comments
 (0)