Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: internal CSS variables aren't exported for Slider component #33668

Open
2 tasks done
soniaboller opened this issue Jan 15, 2025 · 0 comments · May be fixed by #33682
Open
2 tasks done

[Bug]: internal CSS variables aren't exported for Slider component #33668

soniaboller opened this issue Jan 15, 2025 · 0 comments · May be fixed by #33682

Comments

@soniaboller
Copy link

soniaboller commented Jan 15, 2025

Component

Slider

Package version

9.55.1

React version

17.0.2

Environment

System:
    OS: macOS 15.2
    CPU: (14) arm64 Apple M3 Max
    Memory: 1.33 GB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Edge: 131.0.2903.147
    Safari: 18.2
  npmPackages:
    @fluentui/react-components: 9.55.1 => 9.55.1 
    @fluentui/react-icons: 2.0.239 => 2.0.239 
    @fluentui/react-jsx-runtime: 9.0.42 => 9.0.42 
    @fluentui/react-shared-contexts: 9.20.0 => 9.20.0 
    @fluentui/react-utilities: 9.18.13 => 9.18.13 
    @types/react: 17.0.83 => 17.0.83 
    @types/react-dom: 17.0.25 => 17.0.25 
    react: 17.0.2 => 17.0.2 
    react-dom: 17.0.2 => 17.0.2

Current Behavior

Internal CSS variables are not exported.

Expected Behavior

The internal CSS variables should be exported so we can reference them rather than redefining them in case they change.

Reproduction

https://stackblitz.com/edit/e16emsbd?file=src%2Fexample.tsx

Steps to reproduce

Navigate to packages/react-components/react-slider/library/src/index.ts and note that the Internal CSS variables are not exported.

Image

^ packages/react-components/react-slider/library/src/components/Slider/useSliderStyles.styles.ts

Image

Are you reporting an Accessibility issue?

no

Suggested severity

Medium - Has workaround

Products/sites affected

SFE

Are you willing to submit a PR to fix?

yes, but if it's an easy fix on your end then I'd prefer not to

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@soniaboller soniaboller changed the title [Bug]: internal CSS variables aren't exported [Bug]: internal CSS variables aren't exported for Slider component Jan 15, 2025
@ValentinaKozlova ValentinaKozlova linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants