-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X icon in banner is not getting hidden although am setting the dismissable to false for GlobalMessageBanner #12
Comments
Hello, were you able to hide the X icon? |
works for me |
@gitnubster is this still working for you? What did you use when added the banner via API? I tried is with the parameter |
@SebastianSchuetze, I purely use the extension for settings messages, not via api. The extension itself uses api, and has data that can be read as json directly in browser as well: https://dev.azure.com/orgname/_apis/settings/entries/host/GlobalMessageBanners I can't find any property named But if I use the dismiss / X button, a post happens to: |
Thx @gitnubster . I was referring to the initial posters answer to ask how to hide the X button which supposed make the banners non disposable for users. You said it worked for you. The docs for the modals components state that there is a disposable button although I haven't seen it working for banners in AzDo. So we're you able to make banners non disposable? |
@SebastianSchuetze My bad, didn't read well more than once 👎 Until now I've read it as "are you able dismiss any message that is shown, by clicking the X button?". But there is no such thing as And I think all messages should stay dismissable at all times. Because, what if many messages are to be shown? Only one of the same importance level is shown at a time. Which could imply another important message with the same importance level will never become visible, because that one none-dismissable message is on top of the list... That could be a nightmare. |
X icon in banner is not getting hidden although am setting the dismissable to false for GlobalMessageBanner
![image](https://user-images.githubusercontent.com/44192409/75975948-73c23400-5eff-11ea-9b84-3f15fc74c351.png)
The text was updated successfully, but these errors were encountered: