Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X icon in banner is not getting hidden although am setting the dismissable to false for GlobalMessageBanner #12

Open
shilparama opened this issue Mar 5, 2020 · 6 comments

Comments

@shilparama
Copy link

X icon in banner is not getting hidden although am setting the dismissable to false for GlobalMessageBanner
image

@yash-github01
Copy link

Hello, were you able to hide the X icon?

@gitnubster
Copy link

works for me

@SebastianSchuetze
Copy link

@gitnubster is this still working for you? What did you use when added the banner via API? I tried is with the parameter "dismissable": false but it does not work for me. Do you still have the exact syntax for pushing the message and does it still work today?

@gitnubster
Copy link

gitnubster commented Oct 25, 2023

@SebastianSchuetze, I purely use the extension for settings messages, not via api. The extension itself uses api, and has data that can be read as json directly in browser as well: https://dev.azure.com/orgname/_apis/settings/entries/host/GlobalMessageBanners
Here you can find all banners ever created (and not have been deleted yet)

I can't find any property named dismissable in the git repo though... where did you get that from?

But if I use the dismiss / X button, a post happens to:
https://dev.azure.com/orgname/_apis/Settings/Entries/me
Check if there is something weird here perhaps... But don't get confused by all json there, it is one big pile of settings stored for ADO personalization, it seems.
Or check with f12 dev tools in the browser when you click the X button to see if any error messages are there.

@SebastianSchuetze
Copy link

Thx @gitnubster . I was referring to the initial posters answer to ask how to hide the X button which supposed make the banners non disposable for users. You said it worked for you. The docs for the modals components state that there is a disposable button although I haven't seen it working for banners in AzDo.

So we're you able to make banners non disposable?

@gitnubster
Copy link

@SebastianSchuetze My bad, didn't read well more than once 👎 Until now I've read it as "are you able dismiss any message that is shown, by clicking the X button?".

But there is no such thing as dismissable: false, as far as I can tell by reading the globalmessagebanner's code and my own user experience with this extension. I think it is technically not possible to have the X button non-dismissable. So actually, I was not able to make it non-dismissable.

And I think all messages should stay dismissable at all times. Because, what if many messages are to be shown? Only one of the same importance level is shown at a time. Which could imply another important message with the same importance level will never become visible, because that one none-dismissable message is on top of the list... That could be a nightmare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants