toolkit expects %check section to not actually fail package build (when mariner-check-macros is installed)

[ddstreetmicrosoft]

The mariner-check-macros rpm (from the mariner-rpm-macros package) installs a macros file macros.check which overrides parts of the rpm build check section operation and intentionally prevents the result of the check section from causing the build to fail.

This is a bad design since normal users would never expect the rpmbuild check section to fail but the build continue and complete successfully. The toolkit code looks back into the log file to try to parse out if the check section failed or not; normal users should not need to do this.

Hence the toolkit design on this point is wrong and needs to be fixed; the rpmbuild check section should not be overridden to cause it to not fail. The toolkit can easily change how it performs rpm builds if it needs to be able to perform build and check operations separately.

[ddstreetmicrosoft]

@dmcilvaney @PawelWMS @anphel31

[dmcilvaney]

This was a work around for a limitation in the very old build system (mariner1 era). This should be something we can resolve now with the modern build tools since they don't require non-fatal tests.