Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart 2.0 Workflow fails probably because of yaml parsing 1.20 -> go 1.2 #7191

Open
fwilhe2 opened this issue Jan 7, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@fwilhe2
Copy link

fwilhe2 commented Jan 7, 2024

Just noticed that all available runs of the 'quick start 2.0' workflow failed probably because of this weird yaml thing where go 1.20 is parsed as version 1.2. The fix should be to quote the version number so it is a string.

image

I'm not sure if this is actually causing the error, but I guess the setup-go action can't deal with that ancient go version.

@fwilhe2 fwilhe2 added the bug Something isn't working label Jan 7, 2024
@Ankita13-code
Copy link
Contributor

Hi @fwilhe2
I'm a new here and have been trying out Mariner for quite some time now and I want to start making some contributions. I'd like to take up this issue. Could you please assign it to me?

@fwilhe2
Copy link
Author

fwilhe2 commented Jan 8, 2024

Hi @Ankita13-code, I don't work for MSFT and I never contributed to this repo, so I can't assign you. I was just curious that this seems to be broken for so long without any issue or PR I could find to address the issue. Hope some of the maintainers can help you.

@cwyborny
Copy link

cwyborny commented Jan 9, 2024

I have this failure daily on my fork with this error: The process '/usr/bin/git' failed with exit code 1
Not sure how I can fix that..

@fwilhe2
Copy link
Author

fwilhe2 commented Jan 9, 2024

Not sure how I can fix that..

Your fork does not have a '2.0-stable' tag, cf https://github.com/microsoft/CBL-Mariner/tree/2.0-stable. That's not related to the issue I opened.

If you push/create that tag it should fail with the same error as upstream. I think you can select this when forking a repo on github.

@dmcilvaney
Copy link
Contributor

Hey, thanks for noticing this!

I ran into something similar a while ago, might be inspiration for a fix (#6329).

If you want to take another swing at a fix go for it, otherwise I'll take a look in a bit and see if I can figure out what's going wrong.

@dmcilvaney dmcilvaney self-assigned this Jan 17, 2024
@fwilhe2
Copy link
Author

fwilhe2 commented Jan 17, 2024

Hi @dmcilvaney, please go ahead, I'm not planning to work on this. Just wanted to know if my guess about the low effort fix was right, but obviously it was not.

@mfrw
Copy link
Member

mfrw commented Jan 18, 2024

Unsure, if :

fixes it ?

/cc @dmcilvaney

@mfrw
Copy link
Member

mfrw commented Feb 7, 2024

Hi @fwilhe2 I'm a new here and have been trying out Mariner for quite some time now and I want to start making some contributions. I'd like to take up this issue. Could you please assign it to me?

@Ankita13-code - Feel free to take a stab at it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants