-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include CMake package files with GRPC and protobuf devel RPMs #3488
Comments
Did a little bit of digging, this is a bit harder than I previously thought due to the version of protobuf we ship. The main sticking points:
So, not much we can do here other than manually configuring and installing the relevant CMake files. I'm not comfortable doing so due to unfamiliarity with CMake, so I'll unassign myself from this bug. Happy to take a PR fixing this. Otherwise, this change will happen in 3.0 when we'll switch to the CMake-based build. |
I can wait for the 3.0 release. Thanks for investigating. |
The GRPC and protobuf devel RPMs include only pkg-config files. Is there a specific reason why the CMake package files are not included?
Building GRPC and protobuf applications with CMake is greatly simplified by using the protobuf_generate function included in protobuf-config.cmake.
Not sure what the overall strategy is, I see CMake package files included when installing other libraries. Seems if a library generates CMake package files they should be included with the RPM.
Thank you
The text was updated successfully, but these errors were encountered: