Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dirmngr to gpg2 #8349

Open
wants to merge 2 commits into
base: 2.0
Choose a base branch
from
Open

Conversation

readefries
Copy link

This is required to encrypt files. Using an e-mail address with PGP, this will try to look up the key using WKD. This will resolve #3142, broken from CBL Mariner v1 to v2.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • This will add the optional sub-package dirmngr to GnuPG, which is required to lookup keys with WKD.
Does this affect the toolchain?

NO additional packages are required, I just enabled an optional sub-package of GnuPG

Associated issues
Test Methodology
  • Local build on a Azure Linux docker image

@readefries readefries requested a review from a team as a code owner March 12, 2024 12:03
As this is required for encrypting files as GPG will try to look up the key using WKD.
This will resolve microsoft#3142 which was broken when going from CBL Mariner v1 to v2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dirmngr file previously from gnupg2 in Mariner 1.0 missing from 2.0
1 participant