Print all lines, not just error lines, when a tool hits an error

Author: JesseCol

src/winapp-CLI/WinApp.Cli/Services/BuildToolsService.cs

@@ -282,27 +282,6 @@ public async Task<FileInfo> EnsureBuildToolAvailableAsync(string toolName, Cance
         return binPath;
     }
 
-    /// <summary>
-    /// Determines if a line from build tool output contains an error message
-    /// </summary>
-    /// <param name="line">The line to check</param>
-    /// <returns>True if the line contains an error message, false otherwise</returns>
-    private static bool IsErrorLine(string line)
-    {
-        // Here's some example error strings from the tools we call:
-        //   mt.exe: 
-        //      \\?\D:\temp\asdf.manife : general error c1010070: Failed to load and parse the manifest. The system cannot find the file specified.
-        //   signtool.exe:
-        //      SignTool Error: No file digest algorithm specified. Please specify the digest algorithm with the /fd flag. Using ...
-        //   makepri.exe:
-        //      ERROR: PRI180: 0x80070057 - Target noexist.dmp does not exist
-        //   makeappx.exe:
-        //      MakeAppx : error: Package creation failed.
-        //      MakeAppx : error: 0x80080204 - The specified package format is not valid: The package manifest is not valid.
-        
-        return ErrorLineRegex().IsMatch(line);
-    }
-
     /// <summary>
     /// Execute a build tool with the specified arguments
     /// </summary>
@@ -346,32 +325,19 @@ private static bool IsErrorLine(string line)
 
         if (p.ExitCode != 0)
         {
-            // Print lines containing errors from both stdout and stderr when not in verbose mode.
+            // Print lines from both stdout and stderr when not in verbose mode so the user can determine
+            // what went wrong.
             // In verbose mode, all output is already visible via LogDebug above.
             if (!logger.IsEnabled(LogLevel.Debug))
             {
                 if (!string.IsNullOrWhiteSpace(stdout))
                 {
-                    var stdoutLines = stdout.Split('\n', StringSplitOptions.RemoveEmptyEntries);
-                    foreach (var line in stdoutLines)
-                    {
-                        if (IsErrorLine(line))
-                        {
-                            logger.LogError("{ErrorLine}", line);
-                        }
-                    }
+                    logger.LogError("{Stdout}", stdout);
                 }
-                
+
                 if (!string.IsNullOrWhiteSpace(stderr))
                 {
-                    var stderrLines = stderr.Split('\n', StringSplitOptions.RemoveEmptyEntries);
-                    foreach (var line in stderrLines)
-                    {
-                        if (IsErrorLine(line))
-                        {
-                            logger.LogError("{ErrorLine}", line);
-                        }
-                    }
+                    logger.LogError("{StdErr}", stderr);
                 }
             }
 
@@ -397,11 +363,4 @@ public InvalidBuildToolException(int processId, string stdout, string stderr, st
 
     [GeneratedRegex(@"^\d+\.\d+\.\d+\.\d+$")]
     private static partial Regex VersionFolderRegex();
-
-    // Recognize lines that look like error information.
-    // Example strings we want to match:
-    //   error:
-    //   general error c1010070:
-    [GeneratedRegex(@"error\s+[a-z]?\d+:|error:", RegexOptions.IgnoreCase)]
-    private static partial Regex ErrorLineRegex();
 }