Skip to content

Commit 2aaa8e7

Browse files
committed
Normalize max_severity casing to match the lowercased severity filter
Addresses the remaining review note: the severity filter/sort lowercases before comparing, so store the lowercased value in max_severity (and the description) too — correct even if pyatr emits mixed-case severities.
1 parent 63f033c commit 2aaa8e7

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

pyrit/score/true_false/agent_threat_rules_scorer.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,15 @@ async def _score_piece_async(self, message_piece: MessagePiece, *, objective: st
127127
tags = getattr(top, "tags", None) or {}
128128
category = tags.get("category", "")
129129
rule_ids = ",".join(m.rule_id for m in hits)
130-
description = f"Matched {len(hits)} ATR rule(s); highest severity {top.severity}."
130+
# Normalize casing so the stored max_severity matches the lowercased
131+
# value the severity filter/sort compares against.
132+
top_severity = (top.severity or "").lower()
133+
description = f"Matched {len(hits)} ATR rule(s); highest severity {top_severity}."
131134
rationale = f"ATR rules [{rule_ids}] matched at or above severity '{self._min_severity}'."
132135
metadata: dict | None = {
133136
"matched_rule_ids": rule_ids,
134137
"match_count": len(hits),
135-
"max_severity": top.severity,
138+
"max_severity": top_severity,
136139
"atr_category": category,
137140
}
138141
score_categories = [category] if category else self._score_categories

0 commit comments

Comments
 (0)